Repository navigation
Make AreStatic/AreNotStatic agree with BeStatic/NotBeStatic on unknown state - #485
Merged
Merged
Conversation
…nknown state IMember.IsStatic is null for stub members, i.e. members built from a MethodReference or FieldReference rather than a definition. The two member predicates were the only two of the 24 HasValue guards under Elements/ written as "HasValue &&" rather than "!HasValue ||", so for such a member BeStatic and NotBeStatic both passed while neither AreStatic nor AreNotStatic matched. No snapshot changes: every member in every test architecture has a non-null IsStatic, and there is no fluent path to a stub member today, so the fix is not observable from a test. Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
alexanderlinne
enabled auto-merge
August 28, 2026 08:08
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 259 259
Lines 12395 12395
Branches 1206 1206
=======================================
Hits 10226 10226
Misses 1798 1798
Partials 371 371 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mak638
approved these changes
Aug 28, 2026
This was referenced Oct 26, 2026
Bump TngTech.ArchUnitNET and TngTech.ArchUnitNET.xUnit
albandvd/EMA-S9-DS-Gestion-des-dependances#11
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMember.IsStatic is null for stub members, i.e. members built from a MethodReference or FieldReference rather than a definition. The two member predicates were the only two of the 24 HasValue guards under Elements/ written as "HasValue &&" rather than "!HasValue ||", so for such a member BeStatic and NotBeStatic both passed while neither AreStatic nor AreNotStatic matched.
No snapshot changes: every member in every test architecture has a non-null IsStatic, and there is no fluent path to a stub member today, so the fix is not observable from a test.