Repository navigation
Remove Redundant Syntax Element Tests - #488
Merged
Merged
Conversation
Superseded by ObjectSyntaxElementsTests.FollowCustomConditionTest and FollowCustomPredicateTest, which cover the same two syntax elements with snapshots. Its only unique behavior (building its own architecture from the ArchUnitNETTests assembly and using Check()/HasNoViolations()/GetObjects()) isn't custom-syntax-specific and is exercised elsewhere. CustomRuleTestClass was referenced only from within this file, so it goes too. Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
…atTest, extract var should in BeNestedTest/NotBeNestedTest BeDeclaredInTypesThatTest and NotBeDeclaredInTypesThatTest duplicated the "Complex conditions" sub-sections already present in BeDeclaredInTest and NotBeDeclaredInTest - same helper objects, same assertions. Delete the standalone tests rather than the sub-sections; coverage is unaffected since BeDeclaredInTypesThat()/NotBeDeclaredInTypesThat() are already exercised there. TypeSyntaxElementsTests.BeNestedTest/NotBeNestedTest inlined the full Types().That().Are(...).Should() chain on every line instead of extracting `var should = ...` like the rest of the file. No behavior change, so no snapshot changes. Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
alexanderlinne
enabled auto-merge
August 28, 2026 16:01
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
=======================================
Coverage 83.49% 83.49%
=======================================
Files 259 259
Lines 12450 12450
Branches 1210 1210
=======================================
Hits 10395 10395
Misses 1696 1696
Partials 359 359 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mak638
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.