Repository navigation
Bracket component names in OneToOneIfSameParentNamespace arrows - #508
Merged
Merged
Conversation
OneToOneIfSameParentNamespace wrote component names bare where every other arrow brackets them, so "[a] --|> [b]" came out as "a --|> b". That happens to parse while a name is a plain identifier and stops as soon as one is not: ".." collides with PlantUML's dashed-arrow operator, and "*" is not an identifier character at all. Its two mixed component/package arrows had the same problem and no test at all; both are now covered. This went unnoticed because the names drawn by this arrow have so far been plain identifiers. Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
alexanderlinne
enabled auto-merge
October 9, 2026 09:25
mak638
approved these changes
Oct 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 260 260
Lines 12496 12496
Branches 1218 1218
=======================================
Hits 10778 10778
Misses 1379 1379
Partials 339 339 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 26, 2026
Bump TngTech.ArchUnitNET and TngTech.ArchUnitNET.xUnit
albandvd/EMA-S9-DS-Gestion-des-dependances#11
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OneToOneIfSameParentNamespace wrote component names bare where every other arrow brackets them, so "[a] --|> [b]" came out as "a --|> b". That happens to parse while a name is a plain identifier and stops as soon as one is not: ".." collides with PlantUML's dashed-arrow operator, and "*" is not an identifier character at all. Its two mixed component/package arrows had the same problem and no test at all; both are now covered.
This went unnoticed because the names drawn by this arrow have so far been plain identifiers.