feat: click tags in tag library to edit - #987
Closed
rsazra wants to merge 5 commits into
Closed
Conversation
CyanVoxel
added
Type: Bug
Member
|
I apologize for the delay on getting around to reviewing this - It seems that the changes here affect both the "Tag Library" window as well as the "Add Tag" search panel, making it impossible to add tags to file entries as a result. These windows share the same underlying class so it was probably just an oversight. As for the type fixes, they seem all fine and good although I'm a bit weary of using a walrus operator inside an assertion statement, since that's wrapping a necessary variable assignment inside a debug statement. Though it appears many of these type issues have already been fixed upstream, so no need to worry about it? |
Member
|
Closing due to lack of activity |
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in TagStudio Development
TrigamDev
added
Type: Refactor
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After discussion in #426, it's been agreed a single left-click of a tag in the tab library should open the edit modal.
There is some discussion of a larger refactor, and while I think there is room for improvement with
TagWidgetand how it's used, this is more of a quick fix adding the functionality as it is currently intended.I also removed all type errors and warnings in the file, though my techniques for doing so may not be the best. Would be happy to hear suggestions for improvement. These changes are all in the second commit if you'd like to see them (or the functional changes) in isolation.
Tasks Completed