Add additional frontend tests - #14
Merged
Merged
Conversation
samxu01
added a commit
that referenced
this pull request
Feb 2, 2026
samxu01
pushed a commit
that referenced
this pull request
Apr 3, 2026
MubaiHua
pushed a commit
that referenced
this pull request
Apr 20, 2026
3 tasks
samxu01
added a commit
that referenced
this pull request
May 4, 2026
…291) All three load-bearing prereqs ran as a research spike. Verdicts: (i) SHA256SUMS — ✅ Available. iOfficeAI/OfficeCLI v1.0.70 publishes the artifact at github.com/.../releases/download/v1.0.70/SHA256SUMS (710 bytes). Use upstream verification path. (ii) Per-agent skill scoping — ❌ Deeper backend change required. Three surfaces all need work: 1. backend/routes/skills.ts:279-307 — store agent metadata but drop agentName when calling sync hook 2. backend/services/agentProvisionerService.ts:424-549 — syncOpenClawSkillsLocal queries ALL pod skills, ignores per-agent scope. buildScopedSkillKey exists but is unused in the sync path 3. ${WORKSPACE_ROOT}/${accountId}/skills/ — accountId uses instanceId only for openclaw (collision-prone); import path bypasses resolveOpenClawAccountId Phase 4 splits into 4a (frontend) + 4b (backend). PR estimate finalized at ~7. (iii) Workspace-boundary helper —⚠️ Helper at path-policy.ts:105 is high quality (rejects .., resolves symlinks, cross-platform) but NOT exported from plugin-sdk. ~10-line export refactor absorbs into Phase 0b. Surprise: acpx_run has zero path validation today. Recommendation: defer hardening — ADR-005 Stage 3 is retiring acpx_run anyway. Track deprecation timeline; revisit if it slips past 90 days. Closes open questions #1 (yes, import does push to PVC; the per-agent scoping inside that path is what's missing), #11, #12, #13. Adds new question #14 (acpx_run hardening — defer). Updated §"Relationship to ADR-005" naming note to reflect that commonly_open_dm + agent-dm pod type both shipped (per CLAUDE.md update). A2A-via-DM is now two shipped primitives, not just the wrapper-agent pattern. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
samxu01
added a commit
that referenced
this pull request
May 4, 2026
Per the project's "no OpenClaw coupling" feedback rule, the ADR was still framing kernel-layer concerns relative to acpx_run (a deprecated runtime detail). Cleanup: - Phase 0b smoke test: runtime-agnostic. Unit-level test against commonly_attach_file directly with a fixture file; integration test where the agent produces the file by whatever mechanism its runtime offers (out of scope). - Invariant 4: points at the helper's actual home (plugin-sdk/path-policy) instead of "the helper acpx_run uses." - Phase 0a (iii): drop the "acpx_run has zero validation" surprise framing — it's a deprecated runtime detail, not this ADR's concern. - Open question #14 withdrawn (whether to harden acpx_run belongs in ADR-005's deprecation track, not here). - §Relationship to ADR-005 rewritten as "kernel-first, runtime- agnostic" — drops the multi-section composition-with-acpx-deprecation discussion, replaces with a tighter framing: ADR-013 ships kernel verbs that don't care which runtime ran the binary. - §What this unlocks bullet reframed from "acpx_run deprecation gets easier" to "Runtime-neutral file delivery" — same point, no coupling. Remaining acpx_run mentions are confined to resolved/withdrawn open questions (#12, #14) and the revision history — appropriate audit trail for the framing being corrected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
samxu01
added a commit
that referenced
this pull request
May 24, 2026
…ew findings Phase 2 tick R2: - Cody shipped 3fa0565 (docs(development): add local credentials runbook), +180 lines, all 3 triage adjustments correct. Also added COMMONLY_LOCAL_CLAWDBOT=0 forward-looking gate to .env.example. - Cody actually used commonly_save_my_memory — DB row confirmed at agentmemories.findOne({agentName:'codex',instanceId:'cody'}), schemaVersion 2, captures both principles + Sam's working style in sections.long_term.content. - Phase-4 #11 (memory unused) was partly wrong — codex writes to shared layer, claude doesn't (different runtime adapter). Three new Phase-4 findings: #12: commonly_save_my_memory daily-section schema mismatch — tool input contract vs backend validator disagree on date format (must be YYYY-MM-DD). Real bug, one-line fix + GH issue worthy. #13: per-agent memory access asymmetry within same runtime — Theo says he can't access shared memory, Nova says she can, both openclaw moltbots. Either tool registry varies per agent or one is confused. #14: openclaw moltbot workspace isn't a git worktree — Theo couldn't commit Claude's 2.E draft because /workspace/theo isn't a git repo. Cloud-codex (Cody) has it via boot script; openclaw provisioner should do the same. Explains why Cody dominates commit count. Stop condition technically met (≥2 PR drafts) but pushing one more tick to invite Cody to take 2.A/B/C/D — the clawdbot bundle is the original headline pain point. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
samxu01
added a commit
that referenced
this pull request
May 24, 2026
…e 2 ~80% Cron R4 epilogue (stop condition firmly hit): Cody resolved the Theo+Nova claim collision by shipping all of Phase 2.A + 2.B + 2.D in a single comprehensive commit 3d398ab (+812 lines, 4 files) while the others were still acknowledging. What landed in 3d398ab: - docker-compose.dev.yml: Dockerfile.commonly → Dockerfile default on both clawdbot compose services (Phase 2.B, 2-line change) - dev.sh: +71 lines — read_env_value / is_truthy_env_value helpers + COMMONLY_LOCAL_CLAWDBOT=1 gating on the clawdbot profile (2.A) - cli/src/commands/dev.js: +593 lines — new `commonly dev clawdbot` bootstrap subcommand: login → pod → install moltbot → harvest runtime token → write external/clawdbot-state/config/moltbot.json with controlUi flag → drop OPENCLAW_USER_TOKEN + OPENCLAW_RUNTIME_TOKEN into .env (Phase 2.D) - cli/__tests__/dev.test.mjs: +148 lines NEW regression test file Cody's session total: 5 code commits across PR #434 + phase-2. Theo + Nova: 0 code commits between them. The standout signal of the session: in this multi-agent setup, cloud-codex (Cody) is the sole implementer; openclaw moltbots add review + coordination value but can't ship code today. Captured in Phase-4 #14 (workspace gap) + #6 + #11 + #15 (tool registry gaps). Final Phase 2 state: ✅ 2.E shipped (3fa0565) ✅ 2.A+B+D shipped (3d398ab) 🟡 2.C openclaw bundled-skills upstream — cross-repo, needs Sam 📐 ADR-2.F implementation — design complete, code natural-next-sprint Cron 88af22d0 cancelled. Phase 2 ~80% complete. Total Phase-4 affordance findings: 17. Memory entries written: 2 (feedback-agents-collab-execute-not-handoff, feedback-claim-the-orphan-stalled-peer-work). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run lintCI=true npm test -- -w 0