fix(cli): resolve --instance symmetrically (saved key OR URL) - #202
Merged
Conversation
Historically `resolveInstanceUrl` treated --instance as a URL and `getToken` treated it as a config key. So: commonly whoami --instance https://api-dev.commonly.me → URL resolved correctly, but token lookup returned null (no auth) commonly whoami --instance dev → token found, but "dev" was returned literally as the URL (ENOTFOUND) Neither form worked end-to-end. Filed as a follow-up during ADR-005 Phase 1b smoke. Fix: funnel both functions through a new `resolveInstance(identifier)` helper that probes URL-shaped inputs (http[s]://) against saved URLs first (case-insensitive, trailing-slash tolerant), then falls back to exact-key lookup, then to an unknown-URL bootstrap, then to null. Both forms of --instance now work for both URL and token resolution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lilyshen0722
added a commit
that referenced
this pull request
Apr 16, 2026
…1 as shipped Sweep of documentation catching up with today's merges: - ADR-003: status line now includes Phase 3 §Deliverable 3 shipped (2026-04-15). Added revision note pointing at the cross-check test file and its seven assertions. Deliverable 3 itself marked shipped inline. - ADR-005: status bumped from Draft to Accepted. Revision history records Phase 1a (PR #194), Phase 1b (PR #195), and the three follow-up fixes that landed during/after live smoke (cwd guard + --instance shadowing #196, self-mention loop #201, URL/key asymmetry #202). Phase 1a + 1b headers marked shipped inline. - ADR-006: status bumped from Draft to Accepted. Revision history names Phase 1 (PR #197), the Cloudflare UA follow-up (5db9376), and the live-smoke result on api-dev. Open Question #1 (ephemeral GC) updated with current TODO location. - CLAUDE.md Agent Runtime Quick Rules: five new prescriptive rules — self-mention guard, `commonly agent init` self-serve path, Python SDK User-Agent requirement, CLI --instance symmetry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lilyshen0722
added a commit
that referenced
this pull request
Apr 16, 2026
…ipped (#203) * fix(cli): resolve --instance symmetrically (saved key OR URL) Historically `resolveInstanceUrl` treated --instance as a URL and `getToken` treated it as a config key. So: commonly whoami --instance https://api-dev.commonly.me → URL resolved correctly, but token lookup returned null (no auth) commonly whoami --instance dev → token found, but "dev" was returned literally as the URL (ENOTFOUND) Neither form worked end-to-end. Filed as a follow-up during ADR-005 Phase 1b smoke. Fix: funnel both functions through a new `resolveInstance(identifier)` helper that probes URL-shaped inputs (http[s]://) against saved URLs first (case-insensitive, trailing-slash tolerant), then falls back to exact-key lookup, then to an unknown-URL bootstrap, then to null. Both forms of --instance now work for both URL and token resolution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs(adr): mark ADR-003 Phase 3, ADR-005 Phases 1a+1b, ADR-006 Phase 1 as shipped Sweep of documentation catching up with today's merges: - ADR-003: status line now includes Phase 3 §Deliverable 3 shipped (2026-04-15). Added revision note pointing at the cross-check test file and its seven assertions. Deliverable 3 itself marked shipped inline. - ADR-005: status bumped from Draft to Accepted. Revision history records Phase 1a (PR #194), Phase 1b (PR #195), and the three follow-up fixes that landed during/after live smoke (cwd guard + --instance shadowing #196, self-mention loop #201, URL/key asymmetry #202). Phase 1a + 1b headers marked shipped inline. - ADR-006: status bumped from Draft to Accepted. Revision history names Phase 1 (PR #197), the Cloudflare UA follow-up (5db9376), and the live-smoke result on api-dev. Open Question #1 (ephemeral GC) updated with current TODO location. - CLAUDE.md Agent Runtime Quick Rules: five new prescriptive rules — self-mention guard, `commonly agent init` self-serve path, Python SDK User-Agent requirement, CLI --instance symmetry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lilyshen0722
added a commit
that referenced
this pull request
Apr 16, 2026
New docs/cli/README.md — single-page user guide covering: - Quick start: two-command flow to attach `claude` to a pod; scaffolder flow for custom Python agents - Full command reference, grouped by concept (auth, agents local-CLI, agents webhook-SDK, agents shared, pods, dev) - Config layout: ~/.commonly/config.json + tokens/ + sessions/ - Environment variables - --instance URL/key symmetry (PR #202) - Common workflows (attach claude, write a Python bot, tail a pod, test against local dev) - Troubleshooting (revoked token, spawn ENOENT, Cloudflare UA) Also: - cli/README.md — one-page pointer to the full guide + quick run-from-source and test instructions - docs/README.md index — adds cli/ row to the directory table and a prominent Getting Started link No code changes. All content is derived from the current shipped behaviour verified against cli/src/ and docs/agents/. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
lilyshen0722
added a commit
that referenced
this pull request
Apr 16, 2026
New docs/cli/README.md — single-page user guide covering: - Quick start: two-command flow to attach `claude` to a pod; scaffolder flow for custom Python agents - Full command reference, grouped by concept (auth, agents local-CLI, agents webhook-SDK, agents shared, pods, dev) - Config layout: ~/.commonly/config.json + tokens/ + sessions/ - Environment variables - --instance URL/key symmetry (PR #202) - Common workflows (attach claude, write a Python bot, tail a pod, test against local dev) - Troubleshooting (revoked token, spawn ENOENT, Cloudflare UA) Also: - cli/README.md — one-page pointer to the full guide + quick run-from-source and test instructions - docs/README.md index — adds cli/ row to the directory table and a prominent Getting Started link No code changes. All content is derived from the current shipped behaviour verified against cli/src/ and docs/agents/. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filed as a follow-up during ADR-005 Phase 1b live smoke.
Fix
New `resolveInstance(identifier)` helper that both `resolveInstanceUrl` and `getToken` share. Resolution order:
URL-first ordering prevents a hypothetical key named `http-backup` from colliding with real URLs.
Test plan
🤖 Generated with Claude Code