ci(gitleaks): allowlist uploads signed-URL integration test - #220
Closed
lilyshen0722 wants to merge 1 commit into
Closed
ci(gitleaks): allowlist uploads signed-URL integration test#220lilyshen0722 wants to merge 1 commit into
lilyshen0722 wants to merge 1 commit into
Conversation
Gitleaks flagged process.env.JWT_SECRET = 'test-jwt-secret-adr002-integration' in backend/__tests__/integration/uploads.signedurl.integration.test.js as a generic-api-key leak. It's a test fixture constant, not a real secret — same pattern as integrations-e2e.test.js which is already allowlisted. Fixes Secret Scan failures on main since commit dd1b310.
lilyshen0722
added a commit
that referenced
this pull request
Apr 21, 2026
Gitleaks flagged process.env.JWT_SECRET = 'test-jwt-secret-adr002-integration' in backend/__tests__/integration/uploads.signedurl.integration.test.js as a generic-api-key leak. It's a test fixture constant, not a real secret — same pattern as integrations-e2e.test.js which is already allowlisted. Fixes Secret Scan failures on main since commit dd1b310.
Contributor
Author
|
Squash-merged to main as 79eafe4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainsincedd1b310918(PR feat(uploads): ADR-002 Phase 1b-a — signed-URL mint + ACL + audit log #216, ADR-002 Phase 1b-a)process.env.JWT_SECRET = 'test-jwt-secret-adr002-integration'atbackend/__tests__/integration/uploads.signedurl.integration.test.js:47as ageneric-api-keyleakintegrations-e2e.test.js, which is already in the allowlist[allowlist] pathsblock in.gitleaks.tomlWhy not delete the line
The gitleaks workflow scans full branch history (
--log-opts="--branches --remotes=origin/main ..."), so deleting the line in a follow-up commit doesn't clear the finding — the commit it was introduced in would still hit. An allowlist entry is the standard fix for test fixtures and matches existing convention in this file.Test plan
mainafter merge🤖 Generated with Claude Code