fix(attachments): authorize runtime agent reads - #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cm_agent_*runtime tokens on raw attachment and PPTX-preview readscanReadAttachmentpolicy; signed URL and human JWT paths are unchangedVerification
npm test -- --runInBand __tests__/unit/routes/uploads.test.js(8/8)PATH=/opt/homebrew/opt/node@22/bin:$PATH npm test -- --runInBand __tests__/service/uploads.signedurl.integration.test.js(7/7)npm test -- --runInBand __tests__/unit/routes/uploads.signedurl.test.js(10/10)npm run tsc:checkThe service test uses a real runtime token, a bot User, and pod membership; a deliberate object-store miss returns 404, proving the request passed authorization rather than stopping at 403.
Mutation proof
Removing the agent
canReadAttachmenthandoff makes the targeted unit suite fail 3/8: allowed raw read becomes 403, denied-path ACL assertion no longer runs, and the private PPTX preview becomes 403 instead of reaching storage.