Skip to content

Add check-affected job to UI release workflow - #202

Merged
BleedingDev merged 1 commit into
masterfrom
fix/repair-libs/ui-release-pipeline
Dec 14, 2025
Merged

BleedingDev merged 1 commit into
masterfrom
fix/repair-libs/ui-release-pipeline

Conversation

@BleedingDev

@BleedingDev BleedingDev commented Dec 14, 2025 •

Copy link
Copy Markdown
Collaborator

Added a job to check if the UI is affected before release.

Summary by CodeRabbit

Release Notes

This release contains no user-facing changes. Updates have been made to the continuous integration and deployment workflow to optimise the release process, including refinements to build checks and dependency management to ensure more efficient releases of the UI library.

✏️ Tip: You can customize this high-level summary in your review settings.

Added a job to check if the UI is affected before release.
@semanticdiff-com

semanticdiff-com Bot commented Dec 14, 2025 •

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/ui-release.yml  5% smaller

@vercel

vercel Bot commented Dec 14, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
new-engine-ui-storybook Error Error Dec 14, 2025 7:56am

@coderabbitai

coderabbitai Bot commented Dec 14, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

A GitHub Actions workflow enhancement that introduces a conditional job to detect whether the UI library is affected by changes, gating the release job execution based on this determination. Minor cleanup includes removing redundant steps and adding dependency logic.

Changes

Cohort / File(s) Summary
GitHub Actions workflow refinement
\\.github/workflows/ui-release.yml
Added check-affected job using NX to detect UI library impact; made release job conditional and dependent on affected check; removed Enable Corepack step; added pnpm-action-setup; simplified persistence comment

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single workflow file with straightforward conditional logic additions
  • Changes follow conventional CI/CD patterns (job dependency and conditional execution)
  • No complex business logic or multi-file coordination required

Poem

🚀 When changes drift through the PR tide,
A sentinel job stands by our side,
Detecting what's touched with NX's keen sight,
Releasing only when stars align right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarises the main change—adding a check-affected job to the UI release workflow, which aligns with both the file changes and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/repair-libs/ui-release-pipeline

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efddd03 and 1e5b692.

📒 Files selected for processing (1)
  • .github/workflows/ui-release.yml (2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: KaiUweCZE
Repo: NMIT-WR/new-engine PR: 172
File: libs/ui/src/templates/product-card.tsx:77-172
Timestamp: 2025-10-24T06:44:22.155Z
Learning: When reviewing PRs in the NMIT-WR/new-engine repository, check for dependencies on other open PRs before flagging missing types or components as errors. The CI may report errors when a PR depends on changes in another unmerged PR.
📚 Learning: 2025-09-07T21:28:54.320Z
Learnt from: CR
Repo: NMIT-WR/new-engine PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-07T21:28:54.320Z
Learning: Use Nx for orchestrating builds, dev workflows, and affected commands

Applied to files:

  • .github/workflows/ui-release.yml
📚 Learning: 2025-09-07T21:30:50.058Z
Learnt from: CR
Repo: NMIT-WR/new-engine PR: 0
File: libs/ui/CLAUDE.md:0-0
Timestamp: 2025-09-07T21:30:50.058Z
Learning: Run pnpm validate:tokens and pnpm check:unused-tokens during development

Applied to files:

  • .github/workflows/ui-release.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Mesa Review
🔇 Additional comments (3)
.github/workflows/ui-release.yml (3)

59-65: Security improvement and consistency refinements approved.

The addition of persist-credentials: false (line 63) aligns with best practices for OIDC-based trusted publishing. The added pnpm/action-setup@v4 step (line 65) ensures consistency with the check-affected job setup.


13-51: Workflow structure looks good; the conditional release pattern is sound.

The introduction of the check-affected job correctly gates the release job execution based on whether the UI library is actually affected by changes. This avoids unnecessary releases and aligns well with Nx-based orchestration practices.

The dependency chain is properly structured:

  • check-affected establishes NX SHAs via nrwl/nx-set-shas@v4 (line 35)
  • Output is correctly set using modern GitHub Actions syntax (lines 42, 45)
  • Release job properly depends on the check and respects the conditional (lines 50-51)

The grep pattern ^ui$ will correctly match the "ui" project name in Nx's affected projects output format.


37-47: The workflow structure and affected check are correctly configured. The NX project is automatically named ui based on the libs/ui/ directory structure (Nx's plugin autodiscovery uses the directory name when no project.json is present), so the grep pattern ^ui$ will correctly match the project name and releases will proceed as intended.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mesa-dot-dev

mesa-dot-dev Bot commented Dec 14, 2025

Copy link
Copy Markdown

Mesa Description

TL;DR

Added a check-affected job to the UI release workflow to conditionally run the release only when the 'ui' project is impacted by changes.

What changed?

  • .github/workflows/ui-release.yml:
    • Introduced a new check-affected job utilizing Nx to determine if the 'ui' project is affected.
    • Made the release job conditional on the outcome of the check-affected job.
    • Explicitly added pnpm setup to the release job.
    • Removed the corepack enable step.

Description generated by Mesa. Update settings

@mesa-dot-dev mesa-dot-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of efddd03...1e5b692

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

1 files reviewed | 0 comments | Edit Agent Settings • Read Docs

This branch had an error being deployed

1 failed deployment
Preview — 1e5b692b Deployed Dec 14, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant