Repository navigation
Migration/n1 sd - #348
Closed
KaiUweCZE wants to merge 12 commits into
Closed
Migration/n1 sd#348KaiUweCZE wants to merge 12 commits into
KaiUweCZE wants to merge 12 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR integrates the new Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
Collaborator
Author
|
@coderabbitai review pls |
Contributor
|
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 18
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
apps/n1/src/components/prefetch-manager.tsx (1)
43-54:⚠️ Potential issue | 🟠 Majorfix(prefetch-manager): only mark prefetch complete after it actually runs
Line 43 flips
hasPrefetchedbefore the timeout fires. If the effect cleans up first because of a route change, region change, or unmount, the timer is cancelled but the ref staystrue, so later visits will skip root-category prefetch entirely.Suggested patch
- hasPrefetched.current = true - const timer = setTimeout(() => { + hasPrefetched.current = true prefetchLogger.info("Root", `Manager started from ${pathname}`)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/n1/src/components/prefetch-manager.tsx` around lines 43 - 54, hasPrefetched.current is being set to true immediately instead of after the scheduled prefetch runs, so cancelled timers still mark prefetch as done; move the assignment inside the timeout callback (after calling prefetchRootCategories) so hasPrefetched.current is only flipped when the prefetch actually starts, and do not set it in the cleanup path; update the timer callback in the component that uses PREFETCH_DELAYS, prefetchLogger, hasPrefetched, and prefetchRootCategories accordingly.apps/n1/src/utils/format/format-product.ts (1)
21-23:⚠️ Potential issue | 🟠 Majorfix(pricing): stop returning
0 Kčfor every zero-value amount
price ? ...andif (!amount)both treat0as the fallback branch, and that fallback still hard-codesCURRENCY_SYMBOL. In the new currency-aware flow this makes zero-priced EUR/USD products, shipping, and totals render as0 Kč. Please switch to a null/finite check and format zero with the supplied currency.Proposed fix
-import { CURRENCY_SYMBOL, DEFAULT_CURRENCY } from "@/lib/constants" +import { DEFAULT_CURRENCY } from "@/lib/constants" @@ const price = tax ? variant?.calculated_price?.calculated_amount_with_tax : variant?.calculated_price?.calculated_amount_without_tax - const currency = variant?.calculated_price?.currency_code - const currencyMap = currency === "czk" ? CURRENCY_SYMBOL : currency - return price ? `${price.toFixed(0)} ${currencyMap}` : `0 ${CURRENCY_SYMBOL}` + const currency = + variant?.calculated_price?.currency_code?.toUpperCase() ?? DEFAULT_CURRENCY + return formatAmount(price, true, currency) } @@ export const formatAmount = ( amount?: number | null, useGrouping = true, currency = DEFAULT_CURRENCY ) => { - if (!amount) { - return `0 ${CURRENCY_SYMBOL}` + if (typeof amount !== "number" || !Number.isFinite(amount)) { + return new Intl.NumberFormat("cs-CZ", { + style: "currency", + currency, + minimumFractionDigits: 0, + maximumFractionDigits: 0, + useGrouping, + }).format(0) } return new Intl.NumberFormat("cs-CZ", { style: "currency", currency,Also applies to: 46-48
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/n1/src/utils/format/format-product.ts` around lines 21 - 23, The current check treats 0 as falsy and falls back to CURRENCY_SYMBOL, causing zero amounts to render as "0 Kč"; update the logic in format-product.ts to detect real numeric values using a finite/null-safe check (e.g. Number.isFinite or price !== null && isFinite(price)) instead of relying on truthiness, and when price is zero format it with the resolved currencyMap (derived from variant?.calculated_price?.currency_code) rather than hard-coding CURRENCY_SYMBOL; apply the same fix to the other occurrences around the block referenced (the similar logic at the lines noted, e.g., the other price formatting branch).apps/n1/src/app/api/feed/products/route.ts (1)
141-149: 🧹 Nitpick | 🔵 TrivialConsider differentiating error responses.
The error handler returns an empty XML feed with the same cache headers as a successful response. Whilst this provides graceful degradation, it may mask persistent issues from monitoring systems. Consider either:
- Returning a different status code (e.g., 503) with no-cache headers
- Adding a comment/element in the XML indicating an error occurred
- Logging to an external monitoring service
This is a minor observation; the current approach is acceptable if feed availability is prioritised over error visibility.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/n1/src/app/api/feed/products/route.ts` around lines 141 - 149, The catch block currently logs the error and returns an empty XML feed with success cache headers; change it to make errors distinguishable by either returning a non-200 status and no-cache headers or embedding an error element in the XML: capture the caught error in the catch for route handler, call generateXmlFeed or a small helper to produce an error-specific XML (e.g., include an <error> element with a brief message), and return a NextResponse that sets a 503 status and conservative Cache-Control (e.g., no-store, no-cache, must-revalidate) or alternately keep 200 but include the error element; ensure the change is applied around the catch that currently calls generateXmlFeed([]) and constructs the NextResponse so monitoring and clients can detect failures.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/n1/package.json`:
- Around line 22-27: The pnpm lockfile is out of sync with apps/n1/package.json:
`@medusajs/js-sdk` is declared as ^2.13.1 but pnpm-lock.yaml still references
^2.10.3 / resolved 2.12.4; fix by running pnpm install or pnpm update in the
apps/n1 workspace to regenerate pnpm-lock.yaml so it resolves `@medusajs/js-sdk`
to ^2.13.1, then commit the updated pnpm-lock.yaml (ensure the dependency entry
for "@medusajs/js-sdk" in pnpm-lock.yaml matches the package.json spec).
In `@apps/n1/src/app/`(dynamic)/kategorie/[handle]/page.tsx:
- Line 108: The currentPage calculation using Number(searchParams.get("page"))
can yield -1, 1.5, Infinity, etc.; normalize it to a positive integer before
passing to useSuspenseProducts by parsing and clamping: read the raw value via
searchParams.get("page"), convert with Number or parseFloat, ensure
Number.isFinite(raw) and raw > 0, then take Math.floor(raw) (or Math.trunc) and
clamp to at least 1; replace the current const currentPage = Number(...) with
this normalized logic so currentPage is always a finite integer >= 1 when used
by useSuspenseProducts.
- Around line 103-106: breadcrumbItems is currently hardcoded to only "Home" and
rootCategory/handle; instead build it from the category's full parent chain so
the current category appears and links are correct. Locate breadcrumbItems and
replace the two-item array with logic that: 1) starts with { label: "Home",
href: "/" }, 2) maps the full parent chain (e.g., rootCategory.parentChain or
category.parents — use whichever holds the ancestry) into { label: parent.name,
href: `/kategorie/${parent.handle}` } items, and 3) appends the current category
as the final item with its label and no href (so it’s not linkable). Ensure you
reference rootCategory and handle (or category.handle) correctly when building
URLs and preserve optional icon handling if present.
In `@apps/n1/src/app/pokladna/_components/payment-form-section.tsx`:
- Around line 21-25: The useEffect currently depends on the array reference
cart?.payment_collection?.payment_sessions which can trigger unnecessary runs;
change the dependency to the actual provider id value by deriving the provider
id (the same expression used to compute currentProvider) and use that provider
id as the dependency so the effect only runs when provider_id changes; update
the useEffect that calls setSelectedProvider accordingly (referencing useEffect,
setSelectedProvider, and the expression
cart?.payment_collection?.payment_sessions?.[0]?.provider_id).
In `@apps/n1/src/app/pokladna/_components/shipping-method-section.tsx`:
- Around line 40-41: The code computes formattedPrice using
formatShippingOptionDisplayPrice(option, shippingPrices) with a default of
"Zdarma", so remove the redundant fallback at the use site (the `|| "Zdarma"`
after formattedPrice) to avoid double-defaulting; keep the initial default in
the formattedPrice declaration and update any JSX or usages to use
formattedPrice directly (referencing the formattedPrice variable and the
formatShippingOptionDisplayPrice call to locate the change).
In `@apps/n1/src/app/ucet/objednavky/`[id]/_components/order-detail.tsx:
- Around line 50-57: The shipping row currently only renders when
order.shipping_methods?.[0] exists, which hides a non-zero shipping amount;
change the conditional to render based on pricing.hasShipping instead and make
the method label optional by reading order.shipping_methods?.[0]?.name (or
falling back to a generic label). Update the JSX around the conditional that
uses order.shipping_methods?.[0] and pricing.hasShipping in the OrderDetail
component so the row shows whenever pricing.hasShipping is true and the method
name is shown only if order.shipping_methods?.[0]?.name is present.
In `@apps/n1/src/components/header/cart-content.tsx`:
- Around line 124-127: Extract the magic number 1500 into a named constant (e.g.
FREE_SHIPPING_THRESHOLD) at the top of the cart-content.tsx file and replace
both usages: the condition that references pricing.itemsSubtotalAmount and the
subtraction passed to formatAmount (currently 1500 -
pricing.itemsSubtotalAmount). Update any related text if you use the constant
for display (e.g. render FREE_SHIPPING_THRESHOLD in the string) so both logic
and UI read from the same symbol; keep the reference to
pricing.itemsSubtotalAmount and formatAmount intact.
In `@apps/n1/src/components/product-detail/related-products.tsx`:
- Around line 10-15: The component currently calls useProducts with enabled:
hasCategories but still renders the heading/wrapper because an empty array is
truthy; update the component right after the hook (referencing hasCategories,
useProducts, and rawProducts) to return null when there is no category context
(hasCategories === false) or when the query returns no related products
(rawProducts is empty/length === 0) so the related-products section is not
rendered for uncategorised PDPs.
In `@apps/n1/src/hooks/prefetch-utils.ts`:
- Around line 37-41: Currently prefetchLogger.complete is called only after
await prefetch(), so if prefetch() rejects the span remains open; wrap the await
in try/finally: call prefetchLogger.start(type, label) and record start =
performance.now() before awaiting prefetch(), then in a finally block compute
duration = performance.now() - start and call prefetchLogger.complete(type,
label, duration) so the span is always closed even on errors (refer to
prefetch(), prefetchLogger.start, prefetchLogger.complete, and
performance.now()).
In `@apps/n1/src/hooks/use-orders.ts`:
- Around line 73-84: The code is using a type assertion "as OrderDetailInput" in
useOrder which hides a real mismatch between UseOrderInput (id?: string | null)
and OrderDetailInput (id?: string); fix by normalizing the id before calling
orderHooks.useOrder: convert null/undefined to undefined and ensure the payload
matches OrderDetailInput shape (e.g., build an explicit object { id: id ??
undefined } or map fields from UseOrderInput to OrderDetailInput), remove the
unsafe cast, and update the UseOrderInput or OrderDetailInput types if necessary
so they align with the actual hook signature (refer to useOrder, UseOrderInput,
OrderDetailInput, and orderHooks.useOrder to locate the code).
In `@apps/n1/src/hooks/use-prefetch-root-categories.ts`:
- Around line 31-34: The code resets both hasPrefetched.current and
prefetchedRegionId.current when shouldResetPrefetchForRegion(...) is true, but
on the success path only hasPrefetched.current is set to true leaving
prefetchedRegionId.current stale; update the success path(s) to also assign
prefetchedRegionId.current = regionId so both hasPrefetched.current and
prefetchedRegionId.current remain consistent (apply the same change in the other
success location that corresponds to lines 48-49); look for usages in the hook
surrounding shouldResetPrefetchForRegion, hasPrefetched.current, and
prefetchedRegionId.current to make the symmetric update.
In `@apps/n1/src/hooks/use-products.ts`:
- Around line 45-48: Normalize pagination inputs in useProducts before building
listParams: clamp page to at least 1 and ensure limit is a positive integer
(fallback to a safe default if <= 0) and then compute offset = (page - 1) *
limit; update the listParams object(s) (the one using category_id, limit, offset
and the other occurrence later in the file) to use these sanitized values so
negative or zero page/limit never produce invalid offsets.
In `@apps/n1/src/lib/errors.ts`:
- Around line 164-177: The code casts issue.field to AddressFieldKey without
runtime validation, risking invalid keys; update the loop inside the
StorefrontAddressValidationError branch to validate issue.field before using it
as a key (e.g., create a runtime guard/isAddressFieldKey or check against a
whitelist/set of valid AddressFieldKey values) and only assign to
mappedErrors[field] when the field is confirmed valid and issue.message exists,
preserving the final creation of AddressValidationError when mappedErrors is
non-empty.
In `@apps/n1/src/lib/medusa-client.ts`:
- Around line 17-21: The auth object in medusa-client.ts incorrectly includes
jwtTokenStorageMethod which is only valid for JWT auth; remove the
jwtTokenStorageMethod property from the auth config in the client setup (leave
type: "session" and keep fetchCredentials: "include" if needed) so the auth
block follows the session-based pattern used elsewhere (e.g., the auth object in
the Medusa SDK initialization).
In `@apps/n1/src/lib/orders/errors.ts`:
- Line 2: The default Czech message in the constructor of the orders error class
is misspelled; update the constructor's default string from "Objednavka
nenalezena" to the correctly accented "Objednávka nenalezena" in the constructor
used in apps/n1/src/lib/orders/errors.ts (the constructor for the NotFound/order
error class) and ensure the file remains UTF-8 encoded so the diacritic is
preserved in UI/log output.
In `@apps/n1/src/lib/pricing/cart-pricing.ts`:
- Around line 102-104: The taxAmount fallback currently uses order.tax_total ??
order.item_tax_total ?? 0 which omits shipping tax; update the taxAmount
calculation to include shipping tax by using order.tax_total ??
(order.item_tax_total ?? 0) + (order.shipping_tax_total ?? 0) so that both item
and shipping tax components are summed when tax_total is missing; adjust the
variable taxAmount in cart-pricing.ts (where shippingAmount and totalAmount are
defined) to use this summed fallback.
In `@apps/n1/src/lib/product-query-params.ts`:
- Around line 17-29: normalizeCategoryId currently returns [""] for an empty
string and passes through [] unchanged, which can create unwanted query params;
update normalizeCategoryId (function name: normalizeCategoryId, param type:
BuilderParams["category_id"]) to filter out falsy/empty-string values and return
undefined when the resulting array is empty (i.e., convert single string to
[string] then filter out "" and if the final array.length === 0 return
undefined), and if this behavior is intentional add a short comment documenting
why empty values should be preserved.
In `@apps/n1/src/lib/storefront-address-adapter.ts`:
- Around line 18-21: Consolidate the duplicate imports by replacing separate
import lines for cleanPhoneNumber and formatPhoneNumber with a single import
from "@/utils/format/format-phone-number" (e.g., import { cleanPhoneNumber,
formatPhoneNumber } ...) and do the same for cleanPostalCode and
formatPostalCode from "@/utils/format/format-postal-code"; remove the redundant
import statements so only one import per module remains and ensure the
referenced symbols (cleanPhoneNumber, formatPhoneNumber, cleanPostalCode,
formatPostalCode) are preserved where used.
---
Outside diff comments:
In `@apps/n1/src/app/api/feed/products/route.ts`:
- Around line 141-149: The catch block currently logs the error and returns an
empty XML feed with success cache headers; change it to make errors
distinguishable by either returning a non-200 status and no-cache headers or
embedding an error element in the XML: capture the caught error in the catch for
route handler, call generateXmlFeed or a small helper to produce an
error-specific XML (e.g., include an <error> element with a brief message), and
return a NextResponse that sets a 503 status and conservative Cache-Control
(e.g., no-store, no-cache, must-revalidate) or alternately keep 200 but include
the error element; ensure the change is applied around the catch that currently
calls generateXmlFeed([]) and constructs the NextResponse so monitoring and
clients can detect failures.
In `@apps/n1/src/components/prefetch-manager.tsx`:
- Around line 43-54: hasPrefetched.current is being set to true immediately
instead of after the scheduled prefetch runs, so cancelled timers still mark
prefetch as done; move the assignment inside the timeout callback (after calling
prefetchRootCategories) so hasPrefetched.current is only flipped when the
prefetch actually starts, and do not set it in the cleanup path; update the
timer callback in the component that uses PREFETCH_DELAYS, prefetchLogger,
hasPrefetched, and prefetchRootCategories accordingly.
In `@apps/n1/src/utils/format/format-product.ts`:
- Around line 21-23: The current check treats 0 as falsy and falls back to
CURRENCY_SYMBOL, causing zero amounts to render as "0 Kč"; update the logic in
format-product.ts to detect real numeric values using a finite/null-safe check
(e.g. Number.isFinite or price !== null && isFinite(price)) instead of relying
on truthiness, and when price is zero format it with the resolved currencyMap
(derived from variant?.calculated_price?.currency_code) rather than hard-coding
CURRENCY_SYMBOL; apply the same fix to the other occurrences around the block
referenced (the similar logic at the lines noted, e.g., the other price
formatting branch).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 252826b8-5c00-4874-9092-ed735c104bf7
📒 Files selected for processing (82)
apps/n1/next.config.tsapps/n1/package.jsonapps/n1/src/app/(dynamic)/kategorie/[handle]/page.tsxapps/n1/src/app/(dynamic)/produkt/[handle]/error.tsxapps/n1/src/app/(dynamic)/produkt/[handle]/page.tsxapps/n1/src/app/api/feed/products/route.tsapps/n1/src/app/orders/[orderId]/page.tsxapps/n1/src/app/pokladna/_components/address-picker.tsxapps/n1/src/app/pokladna/_components/cart-item-row.tsxapps/n1/src/app/pokladna/_components/checkout-review.tsxapps/n1/src/app/pokladna/_components/order-summary.tsxapps/n1/src/app/pokladna/_components/payment-form-section.tsxapps/n1/src/app/pokladna/_components/save-address-panel.tsxapps/n1/src/app/pokladna/_components/shipping-method-section.tsxapps/n1/src/app/pokladna/_context/checkout-context.tsxapps/n1/src/app/pokladna/page.tsxapps/n1/src/app/prihlaseni/page.tsxapps/n1/src/app/ucet/context/account-context.tsxapps/n1/src/app/ucet/layout.tsxapps/n1/src/app/ucet/objednavky/[id]/_components/order-detail-client.tsxapps/n1/src/app/ucet/objednavky/[id]/_components/order-detail.tsxapps/n1/src/app/ucet/profil/_components/address-list.tsxapps/n1/src/app/ucet/profil/_components/order-list.tsxapps/n1/src/components/address/address-form.tsxapps/n1/src/components/forms/register-form.tsxapps/n1/src/components/header/cart-content.tsxapps/n1/src/components/header/cart-item.tsxapps/n1/src/components/header/desktop-submenu.tsxapps/n1/src/components/molecules/product-grid.tsxapps/n1/src/components/prefetch-manager.tsxapps/n1/src/components/product-detail/product-info-panel.tsxapps/n1/src/components/product-detail/product-info-panel/add-to-cart-section.tsxapps/n1/src/components/product-detail/related-products.tsxapps/n1/src/components/provider.tsxapps/n1/src/data/static/categories.tsapps/n1/src/hooks/prefetch-region.tsapps/n1/src/hooks/prefetch-utils.tsapps/n1/src/hooks/storefront-preset.tsapps/n1/src/hooks/use-addresses.tsapps/n1/src/hooks/use-auth.tsapps/n1/src/hooks/use-cart.tsapps/n1/src/hooks/use-checkout-payment.tsapps/n1/src/hooks/use-checkout-shipping.tsapps/n1/src/hooks/use-complete-checkout.tsapps/n1/src/hooks/use-customer.tsapps/n1/src/hooks/use-login.tsapps/n1/src/hooks/use-logout.tsapps/n1/src/hooks/use-orders.tsapps/n1/src/hooks/use-prefetch-pages.tsapps/n1/src/hooks/use-prefetch-product.tsapps/n1/src/hooks/use-prefetch-products.tsapps/n1/src/hooks/use-prefetch-root-categories.tsapps/n1/src/hooks/use-product.tsapps/n1/src/hooks/use-products.tsapps/n1/src/hooks/use-region.tsapps/n1/src/hooks/use-register.tsapps/n1/src/hooks/use-update-cart-address.tsapps/n1/src/lib/errors.tsapps/n1/src/lib/loggers/cache.tsapps/n1/src/lib/loggers/fetch.tsapps/n1/src/lib/medusa-client.tsapps/n1/src/lib/orders/errors.tsapps/n1/src/lib/prefetch-config.tsapps/n1/src/lib/pricing/cart-pricing.tsapps/n1/src/lib/product-query-params.tsapps/n1/src/lib/query-keys.tsapps/n1/src/lib/storefront-address-adapter.tsapps/n1/src/lib/token-utils.tsapps/n1/src/services/auth-service.tsapps/n1/src/services/cart-service.tsapps/n1/src/services/customer-service.tsapps/n1/src/services/order-service.tsapps/n1/src/services/product-service.tsapps/n1/src/tokens/app-components/atoms/_button.cssapps/n1/src/tokens/app-components/atoms/_checkbox.cssapps/n1/src/tokens/app-components/index.cssapps/n1/src/types/cart.tsapps/n1/src/utils/address-helpers.tsapps/n1/src/utils/address-validation.tsapps/n1/src/utils/cart/cart-helpers.tsapps/n1/src/utils/cart/cart-validation.tsapps/n1/src/utils/format/format-product.ts
💤 Files with no reviewable changes (9)
- apps/n1/src/lib/loggers/fetch.ts
- apps/n1/src/services/product-service.ts
- apps/n1/src/services/auth-service.ts
- apps/n1/src/services/order-service.ts
- apps/n1/src/lib/loggers/cache.ts
- apps/n1/src/lib/token-utils.ts
- apps/n1/src/services/cart-service.ts
- apps/n1/src/lib/query-keys.ts
- apps/n1/src/services/customer-service.ts
Collaborator
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Performance Improvements
UI/UX Improvements