Repository navigation
chore(next): align apps on 16.3 preview - #489
Conversation
|
Review changes with Changed Files
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughBumps Next.js to ChangesNext.js version alignment and Popover import migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR aligns all Next.js-consuming apps (
Confidence Score: 5/5Safe to merge — this is a focused dependency alignment with no logic changes beyond import path corrections that Next 16.3 itself required. All changes are version pins and import path migrations. The popover import changes are mechanically consistent across every call site, props are identical, and the removal of the stale herbatika app-level lockfile consolidates resolution into the root lockfile correctly. No new runtime behaviour is introduced. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Apps["Apps (next: 16.3.0-preview.5)"]
A[n1]
B[herbatika]
C[frontend-demo]
D[payload]
end
subgraph Libs["Libraries"]
E["analytics\n(peerDep: ^16.3.0-preview.5)"]
end
subgraph UIKit["@techsio/ui-kit"]
F["molecules/popover\n(old — removed from imports)"]
G["templates/popover\n(PopoverTemplate — new)"]
end
A -->|imports| G
B -->|no popover| G
C -->|imports| G
D -->|no popover| G
E --> Apps
C -- "auth-dropdown.tsx\nheader.tsx\nheader-search.tsx\nnavigation.tsx" --> G
A -- "cart-popover.tsx\nlogin-popover.tsx" --> G
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
subgraph Apps["Apps (next: 16.3.0-preview.5)"]
A[n1]
B[herbatika]
C[frontend-demo]
D[payload]
end
subgraph Libs["Libraries"]
E["analytics\n(peerDep: ^16.3.0-preview.5)"]
end
subgraph UIKit["@techsio/ui-kit"]
F["molecules/popover\n(old — removed from imports)"]
G["templates/popover\n(PopoverTemplate — new)"]
end
A -->|imports| G
B -->|no popover| G
C -->|imports| G
D -->|no popover| G
E --> Apps
C -- "auth-dropdown.tsx\nheader.tsx\nheader-search.tsx\nnavigation.tsx" --> G
A -- "cart-popover.tsx\nlogin-popover.tsx" --> G
Reviews (3): Last reviewed commit: "fix(next): address preview alignment rev..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12b888e0a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/frontend-demo/src/components/header.tsx`:
- Line 112: The `header` component’s focus-visible outline classes include both
explicit typed outline utilities and a trailing `focus-visible:outline-ring`;
review the `className` on the mobile menu button and remove the redundant
shorthand if the typed `outline-(style:…)`, `outline-(length:…)`, and
`outline-offset-(length:…)` utilities are meant to fully define the outline,
otherwise keep it only if the color override is intentional.
In `@libs/analytics/package.json`:
- Around line 48-51: The analytics package is pinning the Next.js peer
dependency too tightly, which blocks consumers using nearby compatible releases.
Update the peerDependencies entry for next in the package.json for the analytics
library to a version range instead of the exact 16.3.0-preview.5 build, while
keeping the react and react-dom peer constraints unchanged. Use the existing
peerDependencies block as the location to adjust this policy, and if strict
single-version enforcement is still desired, handle that separately from the
published peer range.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: dd044563-aab4-4387-9030-67e75a60dcbc
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (11)
apps/frontend-demo/package.jsonapps/frontend-demo/src/components/auth/auth-dropdown.tsxapps/frontend-demo/src/components/header.tsxapps/frontend-demo/src/components/molecules/header-search.tsxapps/frontend-demo/src/components/molecules/navigation.tsxapps/herbatika/package.jsonapps/n1/package.jsonapps/n1/src/components/header/cart-popover.tsxapps/n1/src/components/header/login-popover.tsxapps/payload/package.jsonlibs/analytics/package.json
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: Greptile Review
⚠️ CI failures not shown inline (5)
GitHub Actions: CI / main: chore(next): align apps on 16.3 preview
Conclusion: failure
##[group]Run pnpm install --frozen-lockfile
�[36;1mpnpm install --frozen-lockfile�[0m
shell: /usr/bin/bash -e {0}
env:
NEXT_PUBLIC_MEDUSA_PUBLISHABLE_KEY: ***
NX_NO_CLOUD: true
PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
##[endgroup]
Scope: all 13 workspace projects
? Verifying lockfile against supply-chain policies (3594 entries)...
Lockfile is up to date, resolution step is skipped
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +3474
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 3474, reused 0, downloaded 0, added 0
Progress: resolved 3474, reused 0, downloaded 1, added 0
Progress: resolved 3474, reused 3, downloaded 59, added 0
Progress: resolved 3474, reused 3, downloaded 106, added 4
Progress: resolved 3474, reused 3, downloaded 226, added 16
Progress: resolved 3474, reused 3, downloaded 333, added 24
Progress: resolved 3474, reused 3, downloaded 419, added 32
Progress: resolved 3474, reused 3, downloaded 458, added 40
[WARN] Request took 10782ms: https://registry.npmjs.org/@graphql-codegen%2Fvisitor-plugin-common
Progress: resolved 3474, reused 3, downloaded 496, added 44
Progress: resolved 3474, reused 3, downloaded 531, added 48
Progress: resolved 3474, reused 3, downloaded 549, added 52
Progress: resolved 3474, reused 3, downloaded 599, added 54
Progress: resolved 3474, reused 3, downloaded 656, added 57
[WARN] Request took 11746ms: https://registry.npmjs.org/@payloadcms%2Fui
Progress: resolved 3474, reused 3, downloaded 764, added 64
Progress: resolved 3474, reused 3, downloaded 845, added 72
Progress: resolved 3474, reused 3, downloaded 890, added 76
Progress: resolved 3474, reused 3, downloaded 917, added 80
[WARN] Request took 12107ms: https://registry.npmjs.org/@typescript-eslint%2Fscope-manager
Progress: resolved 3474, reused 3, downloaded 953, added 82
Progress: resolved 3474, reused 3, downloaded 985, added 84
[WARN] Request t...
GitHub Actions: CI / 0_main.txt: chore(next): align apps on 16.3 preview
Conclusion: failure
##[group]Run pnpm install --frozen-lockfile
�[36;1mpnpm install --frozen-lockfile�[0m
shell: /usr/bin/bash -e {0}
env:
NEXT_PUBLIC_MEDUSA_PUBLISHABLE_KEY: ***
NX_NO_CLOUD: true
PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
##[endgroup]
Scope: all 13 workspace projects
? Verifying lockfile against supply-chain policies (3594 entries)...
Lockfile is up to date, resolution step is skipped
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +3474
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 3474, reused 0, downloaded 0, added 0
Progress: resolved 3474, reused 0, downloaded 1, added 0
Progress: resolved 3474, reused 3, downloaded 59, added 0
Progress: resolved 3474, reused 3, downloaded 106, added 4
Progress: resolved 3474, reused 3, downloaded 226, added 16
Progress: resolved 3474, reused 3, downloaded 333, added 24
Progress: resolved 3474, reused 3, downloaded 419, added 32
Progress: resolved 3474, reused 3, downloaded 458, added 40
[WARN] Request took 10782ms: https://registry.npmjs.org/@graphql-codegen%2Fvisitor-plugin-common
Progress: resolved 3474, reused 3, downloaded 496, added 44
Progress: resolved 3474, reused 3, downloaded 531, added 48
Progress: resolved 3474, reused 3, downloaded 549, added 52
Progress: resolved 3474, reused 3, downloaded 599, added 54
Progress: resolved 3474, reused 3, downloaded 656, added 57
[WARN] Request took 11746ms: https://registry.npmjs.org/@payloadcms%2Fui
Progress: resolved 3474, reused 3, downloaded 764, added 64
Progress: resolved 3474, reused 3, downloaded 845, added 72
Progress: resolved 3474, reused 3, downloaded 890, added 76
Progress: resolved 3474, reused 3, downloaded 917, added 80
[WARN] Request took 12107ms: https://registry.npmjs.org/@typescript-eslint%2Fscope-manager
Progress: resolved 3474, reused 3, downloaded 953, added 82
Progress: resolved 3474, reused 3, downloaded 985, added 84
[WARN] Request t...
GitHub Actions: Storybook A11y (APCA) / 0_storybook-a11y _ storybook-a11y.txt: chore(next): align apps on 16.3 preview
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1mcmd="pnpm install --frozen-lockfile && timeout 420 pnpm -C {{workdir}} exec playwright install --only-shell chromium"�[0m
�[36;1mcmd="${cmd//\{\{workdir\}\}/libs/ui}"�[0m
�[36;1mecho "Running: $cmd"�[0m
�[36;1meval "$cmd"�[0m
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
WORKDIR: libs/ui
REPORT_ROOT: libs/ui/a11y-report
STATIC_DIR: libs/ui/storybook-static
BASE_URL: http://127.0.0.1:6006/
PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
##[endgroup]
Running: pnpm install --frozen-lockfile && timeout 420 pnpm -C libs/ui exec playwright install --only-shell chromium
Scope: all 13 workspace projects
? Verifying lockfile against supply-chain policies (3594 entries)...
Lockfile is up to date, resolution step is skipped
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +3474
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 3474, reused 0, downloaded 0, added 0
Progress: resolved 3474, reused 0, downloaded 1, added 0
Progress: resolved 3474, reused 3, downloaded 61, added 0
Progress: resolved 3474, reused 3, downloaded 131, added 8
Progress: resolved 3474, reused 3, downloaded 254, added 16
Progress: resolved 3474, reused 3, downloaded 361, added 32
Progress: resolved 3474, reused 3, downloaded 407, added 42
Progress: resolved 3474, reused 3, downloaded 429, added 46
Progress: resolved 3474, reused 3, downloaded 463, added 50
Progress: resolved 3474, reused 3, downloaded 498, added 54
Progress: resolved 3474, reused 3, downloaded 530, added 55
[WARN] Request took 10292ms: https://registry.npmjs.org/@prisma%2Finstrumentation
Progress: resolved 3474, reused 3, downloaded 603, added 62
Progress: resolved 3474, reused 3, downloaded 737, added 72
Progress: resolved 3474, reused 3, downloaded 825, added 82
Progress: resolved 3474, reused 3, downloaded 895, added 88
[WARN] Reques...
GitHub Actions: Storybook A11y (APCA) / storybook-a11y _ storybook-a11y: chore(next): align apps on 16.3 preview
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1mcmd="pnpm install --frozen-lockfile && timeout 420 pnpm -C {{workdir}} exec playwright install --only-shell chromium"�[0m
�[36;1mcmd="${cmd//\{\{workdir\}\}/libs/ui}"�[0m
�[36;1mecho "Running: $cmd"�[0m
�[36;1meval "$cmd"�[0m
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
WORKDIR: libs/ui
REPORT_ROOT: libs/ui/a11y-report
STATIC_DIR: libs/ui/storybook-static
BASE_URL: http://127.0.0.1:6006/
PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
##[endgroup]
Running: pnpm install --frozen-lockfile && timeout 420 pnpm -C libs/ui exec playwright install --only-shell chromium
Scope: all 13 workspace projects
? Verifying lockfile against supply-chain policies (3594 entries)...
Lockfile is up to date, resolution step is skipped
Progress: resolved 1, reused 0, downloaded 0, added 0
Packages: +3474
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 3474, reused 0, downloaded 0, added 0
Progress: resolved 3474, reused 0, downloaded 1, added 0
Progress: resolved 3474, reused 3, downloaded 61, added 0
Progress: resolved 3474, reused 3, downloaded 131, added 8
Progress: resolved 3474, reused 3, downloaded 254, added 16
Progress: resolved 3474, reused 3, downloaded 361, added 32
Progress: resolved 3474, reused 3, downloaded 407, added 42
Progress: resolved 3474, reused 3, downloaded 429, added 46
Progress: resolved 3474, reused 3, downloaded 463, added 50
Progress: resolved 3474, reused 3, downloaded 498, added 54
Progress: resolved 3474, reused 3, downloaded 530, added 55
[WARN] Request took 10292ms: https://registry.npmjs.org/@prisma%2Finstrumentation
Progress: resolved 3474, reused 3, downloaded 603, added 62
Progress: resolved 3474, reused 3, downloaded 737, added 72
Progress: resolved 3474, reused 3, downloaded 825, added 82
Progress: resolved 3474, reused 3, downloaded 895, added 88
[WARN] Reques...
Commit Status: Vercel: Vercel
Conclusion: failure
Deployment has failed — run this Vercel CLI command: npx vercel inspect dpl_72YNoFPS3ysg33vCc5MxdvWeSkPW --logs
🧰 Additional context used
📓 Path-based instructions (11)
**/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Use pnpm CLI to add dependencies; never edit package.json directly
Files:
apps/n1/package.jsonapps/herbatika/package.jsonapps/payload/package.jsonapps/frontend-demo/package.jsonlibs/analytics/package.json
apps/n1/**/package.json
📄 CodeRabbit inference engine (apps/n1/CLAUDE.md)
Do NOT manually edit
package.json- usepnpm add <pkg>orpnpm add -D <pkg>commands instead
Files:
apps/n1/package.json
apps/herbatika/**
📄 CodeRabbit inference engine (AGENTS.md)
apps/herbatika/**: Read apps/herbatika/AGENTS.md before editing Herbatika app and follow its specific configuration which overrides root assumptions
Herbatika app runs on http://localhost:3001 and routes work through libs/ui/skills and libs/storefront-data/skills workflows
Files:
apps/herbatika/package.json
apps/n1/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (apps/n1/CLAUDE.md)
apps/n1/**/*.{js,jsx,ts,tsx}: Use spacing tokens50-950(e.g.,p-400,gap-600,m-200) in Tailwind classes - NEVER use small/medium/large tokens (sm,md,lg)
Use semantic color tokens (primary,secondary,success,warning,danger,info,fg-primary,fg-secondary,bg-surface,border-primary, etc.) - NEVER use arbitrary color names likebg-gray-100ortext-blue-500
Do NOT use arbitrary Tailwind values likep-[20px]orbg-[#fff]- use predefined spacing and color tokens only
Userefas a prop pattern in React 19 components instead offorwardRef
Do NOT useuseCallbackhook (React 19 has automatic memoization via the React Compiler)
Import UI components from@libs/uiwith the appropriate directory path:@libs/ui/atoms/<component>for atoms,@libs/ui/molecules/<component>for molecules
Import hooks with theuse-naming convention from@/hooks/<hook-name>directory (e.g.,useCart,useAuth,useOrders)
Import services from@/services/<service-name>directory following the<noun>-servicenaming pattern (e.g.,product-service)
Files:
apps/n1/src/components/header/cart-popover.tsxapps/n1/src/components/header/login-popover.tsx
apps/n1/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (apps/n1/AGENTS.md)
No barrel files or re-export-only
index.tsfiles. Import from source files directly (e.g.,import { formatDate } from '@/utils/date/format-date'). This improves traceability, reduces circular dependency risk, and supports Nx module boundary enforcement.
Files:
apps/n1/src/components/header/cart-popover.tsxapps/n1/src/components/header/login-popover.tsx
apps/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Import UI components using the
@techsio/ui-kitnamespace, not@libs/ui, for runtime apps
Files:
apps/n1/src/components/header/cart-popover.tsxapps/frontend-demo/src/components/molecules/header-search.tsxapps/n1/src/components/header/login-popover.tsxapps/frontend-demo/src/components/auth/auth-dropdown.tsxapps/frontend-demo/src/components/molecules/navigation.tsxapps/frontend-demo/src/components/header.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Run Biome linting and formatting only on changed files using 'bunx biome check --write path/to/file'
Files:
apps/n1/src/components/header/cart-popover.tsxapps/frontend-demo/src/components/molecules/header-search.tsxapps/n1/src/components/header/login-popover.tsxapps/frontend-demo/src/components/auth/auth-dropdown.tsxapps/frontend-demo/src/components/molecules/navigation.tsxapps/frontend-demo/src/components/header.tsx
apps/**/!(medusa-be)/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use modern React patterns and React 19 for frontend applications in the monorepo
Files:
apps/n1/src/components/header/cart-popover.tsxapps/frontend-demo/src/components/molecules/header-search.tsxapps/n1/src/components/header/login-popover.tsxapps/frontend-demo/src/components/auth/auth-dropdown.tsxapps/frontend-demo/src/components/molecules/navigation.tsxapps/frontend-demo/src/components/header.tsx
apps/frontend-demo/src/components/@(atoms|molecules|organisms)/*.tsx
📄 CodeRabbit inference engine (apps/frontend-demo/CLAUDE.md)
apps/frontend-demo/src/components/@(atoms|molecules|organisms)/*.tsx: Place app-specific components in apps/frontend-demo/src/components/[atoms|molecules|organisms]/component-name.tsx
In each component TSX file, import its token CSS (e.g., import './_component-name.css')
Define component props with TypeScript interfaces
Use functional components and hooks for implementation
Use tv() with slots for component styles; only add variants/sizes when necessary
Use Tailwind classes mapped to tokens (e.g., bg-button-bg, p-button-sm); never use arbitrary CSS variable values like bg-[var(--...)] or p-[var(--...)]
Do not hardcode colors or spacing in JSX/TSX; use design tokens and/or tv()
Files:
apps/frontend-demo/src/components/molecules/header-search.tsxapps/frontend-demo/src/components/molecules/navigation.tsx
apps/payload/**/package.json
📄 CodeRabbit inference engine (apps/payload/.cursor/rules/components.md)
Pin all
@payloadcms/* packages to the exact same version to avoid dependency version mismatch errors with hooks like useConfig
Files:
apps/payload/package.json
libs/**
📄 CodeRabbit inference engine (AGENTS.md)
Use RSLib for building libraries in the monorepo
Files:
libs/analytics/package.json
🧠 Learnings (7)
📚 Learning: 2026-02-05T14:43:17.404Z
Learnt from: KaiUweCZE
Repo: NMIT-WR/new-engine PR: 324
File: apps/medusa-be/package.json:0-0
Timestamp: 2026-02-05T14:43:17.404Z
Learning: Validate and enforce React 19 compatibility across monorepo workspaces. Since Medusa UI supports React 19 via root package.json overrides and Medusa Cloud prerequisites show React 19 overrides for npm workspaces, ensure workspace root and all relevant package.json files align with React 19 (18+ requirement is satisfied). When reviewing, verify that overrides exist in the root package.json and that dependent packages in apps or packages directories declare React 19 (or compatible) in their peerDependencies or dependencies as appropriate for workspace usage.
Applied to files:
apps/n1/package.jsonapps/herbatika/package.jsonapps/payload/package.jsonapps/frontend-demo/package.jsonlibs/analytics/package.json
📚 Learning: 2026-05-07T19:05:58.339Z
Learnt from: redeyecz
Repo: TechsioCZ/new-engine PR: 390
File: apps/medusa-be/package.json:78-81
Timestamp: 2026-05-07T19:05:58.339Z
Learning: When reviewing changes to `package.json`, do not automatically flag dependency additions/removals as "manually edited" or as "bypassing the pnpm lockfile" just because the `package.json` diff shows only that file changed. First verify whether `pnpm-lock.yaml` is missing the corresponding entries. Since `pnpm add` updates both `package.json` and `pnpm-lock.yaml` together, legitimate changes can appear in the `package.json` diff while still being properly tracked in the lockfile.
Applied to files:
apps/n1/package.jsonapps/herbatika/package.jsonapps/payload/package.jsonapps/frontend-demo/package.jsonlibs/analytics/package.json
📚 Learning: 2026-05-20T15:58:53.048Z
Learnt from: redeyecz
Repo: TechsioCZ/new-engine PR: 413
File: apps/medusa-be/package.json:77-80
Timestamp: 2026-05-20T15:58:53.048Z
Learning: When reviewing monorepo `package.json` files, treat any dependencies/devDependencies using the `paykit-sdk/*` scope (e.g., `paykit-sdk/core`, `paykit-sdk/stripe`, `paykit-sdk/comgate`, `paykit-sdk/gopay`) as coming from the TechsioCZ/new-engine private npm registry. Do not flag dependency version constraints (e.g., `^1.2.0`) as invalid merely because those packages/versions are not found on the public npm registry. Public-web/private-web availability checks against the public npm API are not applicable for these packages; if validation is needed, rely on the private registry/CI install behavior instead.
Applied to files:
apps/n1/package.jsonapps/herbatika/package.jsonapps/payload/package.jsonapps/frontend-demo/package.json
📚 Learning: 2025-12-16T19:45:17.746Z
Learnt from: BleedingDev
Repo: NMIT-WR/new-engine PR: 207
File: libs/ui/src/molecules/select.tsx:50-50
Timestamp: 2025-12-16T19:45:17.746Z
Learning: When reviewing Tailwind classes in TSX/TS files, prefer using square brackets for arbitrary CSS values and complex expressions. Specifically: - Do not use the parentheses syntax (z-(--z-index)) for anything beyond simple CSS variable references; this syntax auto-wraps in var() and cannot handle calc or complex functions. - Use the square brackets syntax (e.g., h-[calc(var(--available-height)-var(--spacing-content))]) for calc expressions, var with calc, and any complex CSS expressions. This rule applies broadly to Tailwind v4 usage in TSX code across the project.
Applied to files:
apps/n1/src/components/header/cart-popover.tsxapps/frontend-demo/src/components/molecules/header-search.tsxapps/n1/src/components/header/login-popover.tsxapps/frontend-demo/src/components/auth/auth-dropdown.tsxapps/frontend-demo/src/components/molecules/navigation.tsxapps/frontend-demo/src/components/header.tsx
📚 Learning: 2026-03-20T08:17:59.136Z
Learnt from: KaiUweCZE
Repo: TechsioCZ/new-engine PR: 353
File: apps/n1/src/hooks/use-prefetch-category-children.ts:24-25
Timestamp: 2026-03-20T08:17:59.136Z
Learning: In TechsioCZ/new-engine’s Next.js app under apps/n1, the app-level Suspense boundary is already provided by the root layout via the Providers component (apps/n1/src/components/provider.tsx). Therefore, hooks that use useSuspenseQuery (and functions/hooks called within the app tree, e.g., hooks like useSuspenseCategoryRegistry) are already covered for correctness and should not require additional local Suspense boundaries at the page/layout level. Adding additional Suspense boundaries is only an optional UX decision for more granular fallback UI, not something required to make the Suspense-enabled queries work.
Applied to files:
apps/n1/src/components/header/cart-popover.tsxapps/n1/src/components/header/login-popover.tsx
📚 Learning: 2026-04-16T08:11:11.954Z
Learnt from: KaiUweCZE
Repo: TechsioCZ/new-engine PR: 352
File: apps/n1/src/app/pokladna/_components/checkout-review.tsx:4-5
Timestamp: 2026-04-16T08:11:11.954Z
Learning: In `apps/n1`, UI components must be imported using the real `techsio/ui-kit` package entrypoints: `techsio/ui-kit/atoms/<component>` and `techsio/ui-kit/molecules/<component>`. Do not flag `techsio/ui-kit/*` imports as incorrect in `apps/n1`—they are the mandated import pattern. (Legacy aliases like `ui/atoms/*` and `ui/molecules/*` are removed for `apps/n1` via its `tsconfig.json`.)
Applied to files:
apps/n1/src/components/header/cart-popover.tsxapps/n1/src/components/header/login-popover.tsx
📚 Learning: 2026-02-10T15:19:38.125Z
Learnt from: KaiUweCZE
Repo: NMIT-WR/new-engine PR: 328
File: apps/frontend-demo/src/components/molecules/header-search.tsx:75-99
Timestamp: 2026-02-10T15:19:38.125Z
Learning: In apps/frontend-demo/src/components/molecules/header-search.tsx, the dataset invariant is that every product has a handle property. The current fallback in handleSelect calls handleSearch(selected) when a product exists but lacks a handle, and this is acceptable only if that invariant always holds. Actionable guidance: 1) Document the invariant and rely on it in code reviews. 2) Add a defensive guard or a test to verify no product arrives without a handle. For future-proofing, consider guarding the fallback (e.g., if (product?.handle) { handleSearch(product) } else { log/throw or skip }) and ensure a log message when the invariant is violated.
Applied to files:
apps/frontend-demo/src/components/molecules/header-search.tsxapps/frontend-demo/src/components/auth/auth-dropdown.tsxapps/frontend-demo/src/components/molecules/navigation.tsxapps/frontend-demo/src/components/header.tsx
🔇 Additional comments (10)
apps/frontend-demo/package.json (1)
27-27: LGTM!apps/herbatika/package.json (1)
33-33: LGTM!apps/n1/package.json (1)
32-32: LGTM!apps/payload/package.json (1)
36-36: LGTM!Also applies to: 54-54
apps/frontend-demo/src/components/auth/auth-dropdown.tsx (1)
6-6: LGTM!apps/frontend-demo/src/components/header.tsx (1)
5-5: LGTM!apps/frontend-demo/src/components/molecules/header-search.tsx (1)
4-4: LGTM!apps/frontend-demo/src/components/molecules/navigation.tsx (1)
3-3: LGTM!apps/n1/src/components/header/cart-popover.tsx (1)
4-4: LGTM!apps/n1/src/components/header/login-popover.tsx (1)
3-3: LGTM!
Storybook A11y Report
LightNo a11y report JSON found for light. Storybook test-runner likely failed before reporting. DarkNo a11y report JSON found for dark. Storybook test-runner likely failed before reporting. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef85eb9fa7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎉 This PR is included in version 0.19.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Notes
Validation
Closes #484
Summary by CodeRabbit