Repository navigation
chore(next): switch apps to Rust React Compiler - #490
Conversation
|
Review changes with Changed Files
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAcross four Next.js apps, ChangesTurbopack Rust React Compiler switch
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Storybook A11y Report
LightNo a11y report JSON found for light. Storybook test-runner likely failed before reporting. DarkNo a11y report JSON found for dark. Storybook test-runner likely failed before reporting. |
Greptile SummaryThis PR migrates four Next.js 16.3 apps (
Confidence Score: 5/5Safe to merge — all four apps confirmed building with Turbopack in production, the lockfile reflects only the four direct-dependency removals, and CI / Docker stages are consistently updated. The change is a straightforward experimental-flag toggle plus build-script flag addition. The two concerns raised in previous review rounds (Turbopack being suppressed by withPayload, and lockfile drift beyond stated scope) were both addressed and confirmed by the author. No new functional regressions are visible in the changed files. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[next build --turbopack] --> B{Turbopack active?}
B -->|Yes - all 4 apps| C[experimental.turbopackRustReactCompiler: true]
B -->|No - fallback| D[reactCompiler: true]
C --> E[Rust React Compiler]
D --> E2[Babel React Compiler via hoisting]
subgraph Apps migrated
F[frontend-demo]
G[herbatika]
H[n1]
I[payload]
end
A --> F & G & H & I
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[next build --turbopack] --> B{Turbopack active?}
B -->|Yes - all 4 apps| C[experimental.turbopackRustReactCompiler: true]
B -->|No - fallback| D[reactCompiler: true]
C --> E[Rust React Compiler]
D --> E2[Babel React Compiler via hoisting]
subgraph Apps migrated
F[frontend-demo]
G[herbatika]
H[n1]
I[payload]
end
A --> F & G & H & I
Reviews (6): Last reviewed commit: "chore: remove stale herbatika webpack tu..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c2bfd0a2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5c2bfd0 to
1ceef84
Compare
1ceef84 to
27bc4e2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 362288fd38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎉 This PR is included in version 0.19.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This branch was successfully deployed
1 participant
Summary
experimental.turbopackRustReactCompilerfor the four Next 16.3 appsbabel-plugin-react-compilerdependencies from those apps after local production builds passed without direct package resolutionCloses #485
Validation
mise exec -- pnpm install --frozen-lockfilemise exec -- bunx biome check --write apps/frontend-demo/next.config.js apps/frontend-demo/package.json apps/n1/next.config.ts apps/n1/package.json apps/payload/next.config.mjs apps/payload/package.jsonmise exec -- pnpm -C apps/frontend-demo exec next buildmise exec -- pnpm -C apps/herbatika buildmise exec -- pnpm -C libs/analytics build && mise exec -- pnpm -C apps/n1 buildmise exec -- env PAYLOAD_SECRET=local-build-secret DATABASE_URL=postgresql://payload:payload@127.0.0.1:5432/payload S3_ENDPOINT=http://127.0.0.1:9000 S3_REGION=us-east-1 S3_BUCKET=payload-media S3_ACCESS_KEY_ID=payload S3_SECRET_ACCESS_KEY=payload-secret pnpm -C apps/payload buildmise exec -- ./node_modules/.bin/nubx --node nx affected -t lint test --files="<changed files>"Summary by CodeRabbit
--turbopack) across affected apps and the development container.babel-plugin-react-compilerdependency from the relevant app package(s).