Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #386.
Make session idle expiration observable without changing the existing idle
semantics, default five-minute timeout, or daemon-global
--session-idleconfiguration.
Changes
last_activity_at_msandidle_timeout_msfields to sessionlist entries.
bsk session listoutput.session_idle_timeoutreason after the idle reapersuccessfully stops a session.
TTL, cleaning expired entries on reads and writes.
system.status.The cache stores only session IDs and monotonic timestamps. It is not persisted
and contains no URL, title, form, or page data.
Compatibility
--session-idleremains daemon-global.responses and older clients can ignore the additional fields.
Validation
Passed locally:
cargo fmt --checkcargo test -p bsk --test cli_parse --locked— 43 passedcargo test -p bsk-protocol --locked— 171 passedcargo test -p bsk daemon::sessions --locked— 8 passedgit diff --checkTwo new
sessions_ipctests could not complete locally because the currentWindows host cannot connect to the test named-pipe endpoint. Hosted CI must
verify: