Skip to content

fix: branch detection in Nuke pipeline#769

Merged
vbreuss merged 1 commit into
mainfrom
topic/fix-nuke-branch-detection
Sep 7, 2025
Merged

fix: branch detection in Nuke pipeline#769
vbreuss merged 1 commit into
mainfrom
topic/fix-nuke-branch-detection

Conversation

@vbreuss

@vbreuss vbreuss commented Sep 7, 2025

Copy link
Copy Markdown
Member

This PR fixes branch detection in the NUKE build pipeline by replacing the deprecated BranchName property with the Repository Insights approach. The change uses the [GitRepository] attribute to get a GitRepository instance and accesses the branch name through its Branch property.

Key Changes

  • Adds GitRepository dependency injection using the [GitRepository] attribute
  • Replaces all BranchName references with Repository.Branch for branch detection

Use the [Repository Insights](https://nuke.build/docs/common/repository/) to detect the branch name.
@vbreuss vbreuss self-assigned this Sep 7, 2025
Copilot AI review requested due to automatic review settings September 7, 2025 20:16
@vbreuss vbreuss added the bug Something isn't working label Sep 7, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes branch detection in the NUKE build pipeline by replacing the deprecated BranchName property with the repository insights approach. The change uses the [GitRepository] attribute to get a GitRepository instance and accesses the branch name through its Branch property.

Key Changes

  • Adds GitRepository dependency injection using the [GitRepository] attribute
  • Replaces all BranchName references with Repository.Branch for branch detection

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Pipeline/Build.cs Adds GitRepository import and declares Repository field with GitRepository attribute
Pipeline/Build.MutationTests.cs Updates branch name checks to use Repository.Branch instead of deprecated BranchName

@vbreuss vbreuss merged commit d8833fc into main Sep 7, 2025
9 checks passed
@vbreuss vbreuss deleted the topic/fix-nuke-branch-detection branch September 7, 2025 20:19
@sonarqubecloud

sonarqubecloud Bot commented Sep 7, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmark Results

Details

BenchmarkDotNet v0.14.0, Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.413
[Host] : .NET 8.0.19 (8.0.1925.36514), X64 RyuJIT AVX2

Job=InProcess Toolchain=InProcessEmitToolchain IterationCount=15
LaunchCount=1 WarmupCount=10

Method Mean Error StdDev Gen0 Gen1 Allocated
Bool_aweXpect 214.5 ns 2.31 ns 2.04 ns 0.0300 - 504 B
Bool_FluentAssertions 251.4 ns 0.85 ns 0.79 ns 0.0567 - 952 B
Bool_TUnit 906.6 ns 5.30 ns 4.96 ns 0.1431 - 2408 B
Equivalency_aweXpect 324,498.1 ns 574.82 ns 509.56 ns 20.0195 0.9766 335556 B
Equivalency_FluentAssertions 2,193,016.9 ns 37,229.48 ns 33,002.97 ns 273.4375 46.8750 4584416 B
Equivalency_TUnit 688,963.6 ns 2,584.37 ns 2,417.42 ns 51.7578 2.9297 880545 B
Int_GreaterThan_aweXpect 244.7 ns 1.18 ns 1.05 ns 0.0486 - 816 B
Int_GreaterThan_FluentAssertions 244.1 ns 1.82 ns 1.71 ns 0.0730 - 1224 B
Int_GreaterThan_TUnit 1,167.2 ns 5.45 ns 5.09 ns 0.1774 - 2984 B
ItemsCount_AtLeast_aweXpect 524.4 ns 8.46 ns 7.92 ns 0.0868 - 1464 B
ItemsCount_AtLeast_FluentAssertions 495.6 ns 4.76 ns 4.22 ns 0.1192 - 2008 B
ItemsCount_AtLeast_TUnit 18,186.7 ns 234.87 ns 208.21 ns 1.6174 - 27480 B
String_aweXpect 439.9 ns 12.59 ns 11.78 ns 0.0734 - 1232 B
String_FluentAssertions 490.3 ns 17.90 ns 16.75 ns 0.1287 - 2168 B
String_TUnit 1,268.1 ns 37.53 ns 35.10 ns 0.1831 - 3072 B
StringArray_aweXpect 1,855.0 ns 33.87 ns 31.68 ns 0.1717 - 2888 B
StringArray_FluentAssertions 1,541.4 ns 13.17 ns 11.67 ns 0.2480 - 4152 B
StringArray_TUnit 3,338.9 ns 34.48 ns 32.26 ns 0.3128 - 5296 B
StringArrayInAnyOrder_aweXpect 2,313.9 ns 19.82 ns 18.54 ns 0.1831 - 3080 B
StringArrayInAnyOrder_FluentAssertions 148,363.2 ns 836.14 ns 741.22 ns 3.4180 - 63352 B
StringArrayInAnyOrder_TUnit 3,995.9 ns 29.69 ns 26.32 ns 0.3815 - 6488 B

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

👽 Mutation Results

Mutation testing badge

aweXpect

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

aweXpect.Core

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

github-actions Bot added a commit that referenced this pull request Sep 7, 2025
github-actions Bot added a commit that referenced this pull request Sep 7, 2025
@github-actions

github-actions Bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

This is addressed in release v2.23.0.

@github-actions github-actions Bot added the state: released The issue is released label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working state: released The issue is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants