Skip to content

#1014 Orchestrator mode falls back to development even when development is not offered - #2

Merged
Tevin2119 merged 2 commits into
fix/mobile-board-exitfrom
delivery/1014-orchestrator-mode-falls-back-to-developm-7cc819d450
Oct 4, 2026
Merged

Tevin2119 merged 2 commits into
fix/mobile-board-exitfrom
delivery/1014-orchestrator-mode-falls-back-to-developm-7cc819d450

Conversation

@Tevin2119

Copy link
Copy Markdown
Owner

Task pingdotgg#1014, run run-7cc819d450. Approved by Tevin Tendai Muparadzi for commit 4270e8c, which passed its checks and the QA gate.

What was asked

Found by qa-attack (zhipu) while testing task task-ddca8decf4.

Steps: On an environment whose /api/teams list does not include a team named development, remember any team on it, enter Orchestrator mode on a new thread, and let the teams load (or enter with nothing remembered). reconcileTeam settles the draft on DELIVERY_DEFAULT_TEAM.
Expected: The draft settles on a team the environment actually offers.
Actual: The draft settles on development, which the Team select does not offer; Start would be refused by the engine with its own problems text. Matches acceptance item 12's literal wording ('starts from development') and the pre-change behavior, where the team was hardcoded with no reconcile at all.

  • Finding: find-0cc73b0281, not blocking, out of scope of the task it was found on, in the code that change delivered
  • Run: run-961ba38e76
  • Candidate tested: bf971f3
  • Evidence: /Users/tevinmuparadzi/.paperclip/polymania/runs/run-961ba38e76/evidence

Done when

  1. On an environment whose team list has no team named development, with a remembered team that is no longer listed, entering Orchestrator mode on a new thread settles the draft on a team from the list once the teams load.
  2. On the same environment with nothing remembered, entering Orchestrator mode on a new thread settles the draft on a team from the list once the teams load.
  3. In both cases the team the draft settles on is the first team the Team select offers, and the select shows it as the chosen team.
  4. In both cases pressing Start with text written sends that offered team, and the engine does not refuse the start for an unknown team.
  5. On an environment that does offer development, a new Orchestrator draft with nothing remembered, or with a remembered team that is gone, still settles on development.
  6. A remembered team that the environment still offers is kept when the teams load.
  7. A team a person chose from the select before the teams loaded is not replaced when they load.
  8. The automatic settling does not change the team remembered for the environment.
  9. When the draft's team is replaced on load, its workflow and seat settings are cleared, as they are today.
  10. On an environment whose team list is empty, Start is held back with plain words saying there is no team to choose, and no start request is sent with development.
  11. The store tests in apps/web/src/state/delivery.test.ts cover a list without development and an empty list, and pass.

Opened by the delivery engine after a person's approval. Merging is a separate step.

delivery engine added 2 commits October 4, 2026 21:17
…not offered

Fixed Orchestrator fallback to use offered teams and added loaded-list availability guards, visible messages, and regression tests.

Task task-9169e8495d, revision 2, run run-7cc819d450.
…not offered

Repaired the typecheck blocker by removing duplicate defaults from the picker test render helper. Retained the existing Orchestrator fallback implementation.

Task task-9169e8495d, revision 2, run run-7cc819d450.
@Tevin2119
Tevin2119 merged commit 2f8189e into fix/mobile-board-exit Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant