Skip to content

Turn lock-checking on only when assertions are enabled #trivial#1032

Merged
nguyenhuy merged 1 commit into
masterfrom
AHRemoveLockingChecksInRelease
Jul 16, 2018
Merged

Turn lock-checking on only when assertions are enabled #trivial#1032
nguyenhuy merged 1 commit into
masterfrom
AHRemoveLockingChecksInRelease

Conversation

@Adlai-Holler

@Adlai-Holler Adlai-Holler commented Jul 16, 2018

Copy link
Copy Markdown
Member

We accidentally landed this being set to 1 for all builds a few days ago (#1024).

@Adlai-Holler
Adlai-Holler requested a review from nguyenhuy July 16, 2018 02:33
@ghost

ghost commented Jul 16, 2018

Copy link
Copy Markdown

🚫 CI failed with log

@nguyenhuy nguyenhuy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@nguyenhuy
nguyenhuy merged commit f2912ec into master Jul 16, 2018
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants