Skip to content

Split up table view thrash tests#1228

Closed
mikezucc wants to merge 4 commits into
TextureGroup:masterfrom
mikezucc:master
Closed

Split up table view thrash tests#1228
mikezucc wants to merge 4 commits into
TextureGroup:masterfrom
mikezucc:master

Conversation

@mikezucc

@mikezucc mikezucc commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

Enabled and split the table view thrash test into a test file and a utility. This is part of an effort to write thrash tests for the collection view as well in order to try and reproduce crazy elusive texture/UIKit sync issues

@mikezucc

mikezucc commented Nov 9, 2018

Copy link
Copy Markdown
Contributor Author

Lol good catch by that bot 👍

@ghost

ghost commented Nov 9, 2018

Copy link
Copy Markdown

🚫 CI failed with log

@mikezucc

Copy link
Copy Markdown
Contributor Author

Fixed the source header 👍

@mikezucc

Copy link
Copy Markdown
Contributor Author

ping @maicki How does this look now?

@mikezucc

Copy link
Copy Markdown
Contributor Author

Pushed a commit to reenable those table view thrash tests

@ghost

ghost commented Nov 19, 2018

Copy link
Copy Markdown
1 Warning
⚠️ This is a big PR, please consider splitting it up to ease code review.

Generated by 🚫 Danger

@mikezucc

Copy link
Copy Markdown
Contributor Author

Closing this in favor of a new PR

@mikezucc mikezucc closed this Nov 20, 2018
@mikezucc

Copy link
Copy Markdown
Contributor Author

New PR #1246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant