Add way to compile out ASTextNode + TextKit dependencies#1242
Merged
Conversation
maicki
force-pushed
the
MSTextNode1CompilerFlag
branch
from
November 18, 2018 21:28
bfca80b to
7863840
Compare
Member
|
Should we also compile out the ASTextNode2 experiment ( |
maicki
force-pushed
the
MSTextNode1CompilerFlag
branch
from
November 22, 2018 18:11
7863840 to
d9d050a
Compare
Contributor
Author
|
I just updated the diff to compile out |
nguyenhuy
approved these changes
Nov 22, 2018
nguyenhuy
left a comment
nguyenhuy
left a comment
Member
There was a problem hiding this comment.
Great to be able to reduce the framework's size when some code is never used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we are having ASTextNode and ASTextNode2 which are adding quit a bit of size to Texture. As it becomes more and more clear that ASTextNode2 gonna be the future of text node within Texture we will provide a way to opt out of ASTextNode and make ASTextNode2 the default by default.
To be able to completly opt out of ASTextNode and all of it's TextKit dependency we are introducing a compiler flag called
AS_ENABLE_TEXTNODE. By default the value isYES / 1to reflect the old behavior.Furthermore there is a CocoaPods subspec added to disable the flag.
If the flag is disabled and ASTextNode2 is used only this will reduce around 300kb of Texture size.