Skip to content

Reduce startup time.#1292

Merged
maicki merged 1 commit into
TextureGroup:masterfrom
dmaclach:static1
Jan 15, 2019
Merged

Reduce startup time.#1292
maicki merged 1 commit into
TextureGroup:masterfrom
dmaclach:static1

Conversation

@dmaclach

Copy link
Copy Markdown
Contributor

Move file scope constant that is initialized at startup to function scope to avoid startup hit.

@ghost

ghost commented Dec 19, 2018

Copy link
Copy Markdown

🚫 CI failed with log

@maicki

maicki commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

The CI failure is not due to changes in this PR. @dmaclach would you mind to rebase from master to restart the CI. Thanks!

@maicki maicki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me

Comment thread Source/ASDisplayNode.mm Outdated
Move file scope constant that is initialized at startup to function scope to avoid startup hit.
@dmaclach

Copy link
Copy Markdown
Contributor Author

Can somebody merge?

@maicki
maicki merged commit e59eff8 into TextureGroup:master Jan 15, 2019
@dmaclach
dmaclach deleted the static1 branch January 15, 2019 17:14
@dmaclach

Copy link
Copy Markdown
Contributor Author

Thank you kindly!

raviTokopedia pushed a commit to raviTokopedia/Texture that referenced this pull request Mar 5, 2020
Move file scope constant that is initialized at startup to function scope to avoid startup hit.

(cherry picked from commit e59eff8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants