Add some snapshot tests for ASTextNode2 truncation modes.#1296
Merged
Conversation
maicki
approved these changes
Dec 21, 2018
maicki
left a comment
maicki
left a comment
Contributor
There was a problem hiding this comment.
@wiseoldduck Except some small styling nits looks good to me. Thanks for adding these and really necessary to keep meeting our high standards of the framework.
nguyenhuy
approved these changes
Dec 22, 2018
nguyenhuy
left a comment
nguyenhuy
left a comment
Member
There was a problem hiding this comment.
Question aside, LGTM overall. Thank you for adding these tests!
|
🚫 CI failed with log |
Member
|
Time to merge. Thanks, @wiseoldduck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should have added these sooner, looks like there is a regression in NSLineBreakModeMiddle :-(