Automatically resume ASVideoNode after returning from background#13
Merged
Adlai-Holler merged 4 commits intoMay 2, 2017
Merged
Conversation
Adlai-Holler
approved these changes
Apr 17, 2017
Adlai-Holler
left a comment
Adlai-Holler
left a comment
Member
There was a problem hiding this comment.
Given Ricky's comments in the original diff, I'm good with this.
Member
|
@plarson Hey, thank you in advance for dealing with our growing pains :D We have a few new requirements as you can see by the Pinterest iOS bot. Thanks again (in advance) for taking care of them. |
Member
|
Hmm shouldn't that license warning only be thrown for new source files? We should do a pass updating the headers for all existing source files. |
Generated by 🚫 Danger |
Member
|
|
Member
|
@plarson Actually, we should have an entry in CHANGELOG. |
Member
|
Alright I don't think we're going to get a changelog entry for this one. No big deal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving PR from facebookarchive/AsyncDisplayKit#3271