Fix deprecated implementations warning#1306
Merged
Merged
Conversation
Adlai-Holler
reviewed
Jan 9, 2019
maicki
force-pushed
the
MSCleanupDeprecatedMethodWarning
branch
from
January 10, 2019 08:04
cdb7966 to
680e6ea
Compare
Contributor
Author
|
@Adlai-Holler Want to give that another look please. Thank! |
nguyenhuy
approved these changes
Jan 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like Xcode 10.1 introduces some new warnings. Either we should prevent them via Xcode settings or like in this PR guard them via a compiler flag.