Skip to content

[ASCollectionView] Supplementary nodes should not enter ASHierarchyStateRangeManaged. #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maicki merged 1 commit into from
Jan 11, 2019
Merged

[ASCollectionView] Supplementary nodes should not enter ASHierarchyStateRangeManaged. #1310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Source/ASCollectionView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2044,17 +2044,23 @@ - (ASCellNodeBlock)dataController:(ASDataController *)dataController supplementa
}

// Wrap the node block
BOOL disableRangeController = ASCellLayoutModeIncludes(ASCellLayoutModeDisableRangeController);
// BOOL disableRangeController = ASCellLayoutModeIncludes(ASCellLayoutModeDisableRangeController);
__weak __typeof__(self) weakSelf = self;
return ^{
__typeof__(self) strongSelf = weakSelf;
ASCellNode *node = block();
ASDisplayNodeAssert([node isKindOfClass:[ASCellNode class]],
@"ASCollectionNode provided a non-ASCellNode! %@, %@", node, strongSelf);

// TODO: ASRangeController doesn't currently support managing interfaceState for supplementary nodes.
// For now, we allow the standard ASInterfaceStateInHierarchy behavior by ensuring we do not inform
// the node that it should expect external management of interfaceState.
/*
if (!disableRangeController) {
[node enterHierarchyState:ASHierarchyStateRangeManaged];
}
*/

if (node.interactionDelegate == nil) {
node.interactionDelegate = strongSelf;
}
Expand Down