Change layoutSizeDifferentFromBounds macro to a BOOL - #1718
Merged
ernestmama merged 1 commit intoNov 11, 2019
Merged
Conversation
Contributor
|
It looks good to me but I am not sure if there is any particular reason to do it that way in the beginning. Would love some eyes from others. |
vovasty
approved these changes
Nov 5, 2019
vovasty
left a comment
vovasty
left a comment
Contributor
There was a problem hiding this comment.
Macro looks ugly. imho much simpler just remove the macro and add a comment about this check.
ernestmama
approved these changes
Nov 11, 2019
hanton
deleted the
change-layoutSizeDifferentFromBounds-macro-to-BOOL
branch
November 11, 2019 23:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than defining
layoutSizeDifferentFromBoundsas a macro, a BOOL can do the job.