Reference Image Updates in preparation for iOSSnapshotTestCase 6.2#1857
Merged
bolsinga merged 1 commit intoMay 28, 2020
Conversation
- Update all the tests identifiers in code to use `_` instead of `-`. -- Rename all the reference images with `_` instead of `-`. -- The above two changes are in preparation for iOSSnapshotTestsCase doing this for us. - Move all the reference images in the path "ReferenceImages_iOS_10" to "ReferenceImages_64". -- When copying these reference images, prefer the iOS10 reference images since we now run under iOS10. -- The exception is testRoundedCornerBlock where we prefer the 64 one. -- Remove "_iOS_10" as a suffix in code.
jparise
approved these changes
May 28, 2020
piotrdebosz
pushed a commit
to getstoryteller/Texture
that referenced
this pull request
Mar 1, 2021
…extureGroup#1857) - Update all the tests identifiers in code to use `_` instead of `-`. -- Rename all the reference images with `_` instead of `-`. -- The above two changes are in preparation for iOSSnapshotTestsCase doing this for us. - Move all the reference images in the path "ReferenceImages_iOS_10" to "ReferenceImages_64". -- When copying these reference images, prefer the iOS10 reference images since we now run under iOS10. -- The exception is testRoundedCornerBlock where we prefer the 64 one. -- Remove "_iOS_10" as a suffix in code. Co-authored-by: Rahul Malik <rmalik@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_instead of-.-- Rename all the reference images with
_instead of-.-- The above two changes are in preparation for iOSSnapshotTestsCase doing this for us.
-- When copying these reference images, prefer the iOS10 reference images since we now run under iOS10.
-- The exception is testRoundedCornerBlock where we prefer the 64 one.
-- Remove "_iOS_10" as a suffix in code.