Skip to content

Improve ThreeMigrationGuide.md #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jparise merged 2 commits into from
Jun 29, 2020
Merged

Improve ThreeMigrationGuide.md #1878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37b3fef
Add `ASImageCacherCompletion` breaking API change.
rogerluan Jun 27, 2020
5297d9b
Remove unnecessary trailing pounds.
rogerluan Jun 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions ThreeMigrationGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
### Texture 3.0 Migration Guide ###
## Texture 3.0 Migration Guide

Got a tip for upgrading? Please open a PR to this document!
Got a tip for upgrading? Please open a PR to this document!


### Breaking API Changes

`ASImageCacherCompletion` typedef has a new parameter: `ASImageCacheType cacheType`. Example:


```swift
ASPINRemoteImageDownloader.shared().cachedImage(with: url, callbackQueue: .main) { result in
…
}
```

Becomes

```swift
ASPINRemoteImageDownloader.shared().cachedImage(with: url, callbackQueue: .main) { result, cacheType in
…
}
```