[example/CustomCollectionView] Implement MosaicCollectionLayoutDelegate#28
Conversation
b5e49fb to
0c74571
Compare
There was a problem hiding this comment.
This new file uses many logics from MosaicCollectionViewLayout.m, hence this version of Copyright Notice.
881d2db to
1b84899
Compare
d8df6ab to
20d2198
Compare
There was a problem hiding this comment.
Just to demonstrate best practice, might be worth having a CGSize imageSize = at the top
There was a problem hiding this comment.
This is a bit complex for sample code -- add a comment above for why it isn't just a dictionary?
There was a problem hiding this comment.
Vector might be worthwhile to avoid boxing - try profiling this first and look for object retain / release overhead. Apps will probably borrow this sample code and ship it :)
There was a problem hiding this comment.
Good point! Since this method is only called once for each data set, and in many cases on a background thread, I left a TODO instead of optimizing now.
appleguy
left a comment
appleguy
left a comment
There was a problem hiding this comment.
@nguyenhuy this is so exciting! I can't wait to try running it locally.
I think it would be worth a couple more performance optimizations for demonstrating best practices in core code, but this is subjective and not a correctness issue.
50bc29e to
9350049
Compare
|
🚫 CI failed with log |
|
Looks like this needs a rebase. |
9350049 to
994a35c
Compare
Generated by 🚫 Danger |
4 participants
This is the first step in turning CustomCollectionView example into a playground for the coming async pager layout. It also helps identify components in the current system that don't play well with
ASCollectionLayoutand need to be improved/by-passed, such as ASRangeController, layout inspector, etc.Ticket: #186