Skip to content

Update contribution guidelines#3

Merged
garrettmoon merged 4 commits into
masterfrom
MSContributionGuidelines
Apr 12, 2017
Merged

Update contribution guidelines#3
garrettmoon merged 4 commits into
masterfrom
MSContributionGuidelines

Conversation

@maicki

@maicki maicki commented Apr 10, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@maicki
maicki requested a review from garrettmoon April 10, 2017 20:01
@CLAassistant

CLAassistant commented Apr 10, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@maicki
maicki force-pushed the MSContributionGuidelines branch from ebc370b to d9b4cae Compare April 10, 2017 20:11
@ghost

ghost commented Apr 10, 2017

Copy link
Copy Markdown

Build failure:

3 similar comments
@ghost

ghost commented Apr 10, 2017

Copy link
Copy Markdown

Build failure:

@ghost

ghost commented Apr 10, 2017

Copy link
Copy Markdown

Build failure:

@ghost

ghost commented Apr 10, 2017

Copy link
Copy Markdown

Build failure:

@garrettmoon garrettmoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once comments are addressed.

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change to http://texturegroup.org/slack.html

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change link to https://github.com/texturegroup/texture/issues?

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update link to http://texturegroup.org/slack.html

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the CLA link: https://cla-assistant.io/TextureGroup/Texture

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache 2. You can also say, see README.md for more details (I'll be updating it).

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the modified file to have this copyright header:

//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.
//  This source code is licensed under the BSD-style license found in the
//  LICENSE file in the root directory of this source tree. An additional grant
//  of patent rights can be found in the PATENTS file in the same directory.
//  Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present,
//  Pinterest, Inc.  Licensed under the Apache License, Version 2.0 (the "License");
//  you may not use this file except in compliance with the License.
//  You may obtain a copy of the License at
//  
//      http://www.apache.org/licenses/LICENSE-2.0
//
//  Unless required by applicable law or agreed to in writing, software
//  distributed under the License is distributed on an "AS IS" BASIS,
//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//  See the License for the specific language governing permissions and
//  limitations under the License.

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the new files can you use this:

//  Copyright (c) 2017-present, Pinterest, Inc.  All rights reserved.
//  Licensed under the Apache License, Version 2.0 (the "License");
//  you may not use this file except in compliance with the License.
//  You may obtain a copy of the License at
//  
//      http://www.apache.org/licenses/LICENSE-2.0
//  
//  Unless required by applicable law or agreed to in writing, software
//  distributed under the License is distributed on an "AS IS" BASIS,
//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//  See the License for the specific language governing permissions and
//  limitations under the License.

@maicki
maicki force-pushed the MSContributionGuidelines branch from 2f336be to f87fef3 Compare April 11, 2017 23:07
@garrettmoon
garrettmoon merged commit 3202959 into master Apr 12, 2017
garrettmoon pushed a commit that referenced this pull request Apr 13, 2017
* Update contribution guidelines

* Some improvements

* Improve code

* Update based on feedback
garrettmoon pushed a commit that referenced this pull request Apr 14, 2017
* Update contribution guidelines

* Some improvements

* Improve code

* Update based on feedback
garrettmoon pushed a commit that referenced this pull request Apr 14, 2017
* Update contribution guidelines

* Some improvements

* Improve code

* Update based on feedback
@maicki
maicki deleted the MSContributionGuidelines branch May 3, 2017 17:52
harryworld pushed a commit to harryworld/Texture that referenced this pull request Aug 28, 2017
wiseoldduck pushed a commit to wiseoldduck/Texture that referenced this pull request Jul 25, 2019
…ir layout due to another node's Yoga properties changing.

Whenever we do a new Yoga layout that is going to be displayed, we call setNeedsLayout on any nodes whose layout has changed.

PRESUBMIT=passed
BUG=126438367
R=adlai,wiseoldduck
CC=goodsons,maicki,maxwang,yt-elements-eng+cl
APPROVED=adlai,wiseoldduck
REQUIRED_REVIEW=1
DELTA=51 (27 added, 17 deleted, 7 changed)
DELTA_BY_EXTENSION=h=3,mm=31
OCL=236253226
FIG_CHANGESET=dfbe7a030652966ffa787b192e70d8b88e365a17
FIG_WORKSPACE=tnorman/3272:ytios


P4 change: 238551043
benniebotha pushed a commit to atlassian-forks/Texture that referenced this pull request Jun 28, 2021
Spm support

Approved-by: Shehab Tareque
Approved-by: Eugene 'Evgeny' Dymov
luoxiu pushed a commit to luoxiu/Texture that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants