Update contribution guidelines#3
Conversation
ebc370b to
d9b4cae
Compare
|
Build failure: |
3 similar comments
|
Build failure: |
|
Build failure: |
|
Build failure: |
0d1adcb to
bd44082
Compare
garrettmoon
left a comment
There was a problem hiding this comment.
Good to go once comments are addressed.
There was a problem hiding this comment.
Can you change to http://texturegroup.org/slack.html
There was a problem hiding this comment.
Can you change link to https://github.com/texturegroup/texture/issues?
There was a problem hiding this comment.
Update link to http://texturegroup.org/slack.html
There was a problem hiding this comment.
Here's the CLA link: https://cla-assistant.io/TextureGroup/Texture
There was a problem hiding this comment.
Apache 2. You can also say, see README.md for more details (I'll be updating it).
There was a problem hiding this comment.
Can you change the modified file to have this copyright header:
// Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
// This source code is licensed under the BSD-style license found in the
// LICENSE file in the root directory of this source tree. An additional grant
// of patent rights can be found in the PATENTS file in the same directory.
// Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present,
// Pinterest, Inc. Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
There was a problem hiding this comment.
For the new files can you use this:
// Copyright (c) 2017-present, Pinterest, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
2f336be to
f87fef3
Compare
* Update contribution guidelines * Some improvements * Improve code * Update based on feedback
* Update contribution guidelines * Some improvements * Improve code * Update based on feedback
* Update contribution guidelines * Some improvements * Improve code * Update based on feedback
merge master into branch
…ir layout due to another node's Yoga properties changing. Whenever we do a new Yoga layout that is going to be displayed, we call setNeedsLayout on any nodes whose layout has changed. PRESUBMIT=passed BUG=126438367 R=adlai,wiseoldduck CC=goodsons,maicki,maxwang,yt-elements-eng+cl APPROVED=adlai,wiseoldduck REQUIRED_REVIEW=1 DELTA=51 (27 added, 17 deleted, 7 changed) DELTA_BY_EXTENSION=h=3,mm=31 OCL=236253226 FIG_CHANGESET=dfbe7a030652966ffa787b192e70d8b88e365a17 FIG_WORKSPACE=tnorman/3272:ytios P4 change: 238551043
Spm support Approved-by: Shehab Tareque Approved-by: Eugene 'Evgeny' Dymov
No description provided.