Adds support for specifying a quality indexed array of URLs#557
Merged
Conversation
|
🚫 CI failed with log |
|
🚫 CI failed with log |
nguyenhuy
approved these changes
Sep 11, 2017
nguyenhuy
left a comment
nguyenhuy
left a comment
Member
There was a problem hiding this comment.
Some questions aside, LGTM!
| [self _locked__setImage:result]; | ||
|
|
||
| _imageLoaded = YES; | ||
| } |
Member
There was a problem hiding this comment.
Looks like we're fetching images from low cost to higher cost and don't bail as soon as there is a cache hit. Does this mean that if there are multiple images, we'll end up fetching all of them but only use the best one? If that's the case, should we instead fetch in reverse order and stop as early as possible?
garrettmoon
force-pushed
the
lowResImages
branch
from
September 11, 2017 17:25
3cf0055 to
524081e
Compare
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…roup#557) * Add support for downloading a set of URLs on ASNetworkImageNode * Should be building now; * Remove old unused code * Add a changelog message * Bump PINRemoteImage * Huy's comments
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…extureGroup#699) * Revert "Adds support for specifying a quality indexed array of URLs (TextureGroup#557)" This reverts commit 3c77d4a. * Add CHANGELOG entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows PINRemoteImage to download from a set of URLs depending on network conditions.
More context perhaps:
pinterest/PINRemoteImage#407
pinterest/PINRemoteImage#403