Use node lock instead of separate one to avoid deadlocks.#582
Merged
Conversation
|
🚫 CI failed with log |
appleguy
approved these changes
Sep 26, 2017
appleguy
left a comment
appleguy
left a comment
Member
There was a problem hiding this comment.
That would do it! This looks correct.
nguyenhuy
force-pushed
the
fixAnimatedDeadlock
branch
from
September 27, 2017 08:26
bd8e0df to
2b6f68d
Compare
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…up#582) * Use node lock instead of separate one to avoid deadlocks. * Add CHANGELOG entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a dumb deadlock thanks to @djblake