[ASNodeController+Beta] Provide an option to allow nodes to own their controllers.#61
Merged
Conversation
… controllers. We should certainly remove this before moving ASNodeController out of Beta. However, I think it will require at least ASCollectionNode to be able to retain its top level set of node controllers. Without this facility built in, it's very difficult for apps supporting both UIKit and ASDK to manually manage the controllers and keep them in sync with perfect timing.
Member
|
Sorry I'm bad at shell scripts so the build failure didn't get reported: |
|
🚫 CI failed with log |
Generated by 🚫 Danger |
Member
Author
|
This is ready for review when folks have a chance. Not at all urgent. It would be great to not need this diff if changes are planned soon to make it unnecessary. However, I think it's perfectly fine if this is not on the priority list for the core team - thus this diff so that there's a good option for clients to work around in the meantime. |
Adlai-Holler
approved these changes
May 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should certainly remove this before moving ASNodeController out of Beta. However, I think
it will require at least ASCollectionNode to be able to retain its top level set of node controllers.
Without this facility built in, it's very difficult for apps supporting both UIKit and ASDK to
manually manage the controllers and keep them in sync with perfect timing.