[CGPointNull] Rename globally exported C function to avoid collisions #trivial#62
Merged
Conversation
Some other frameworks also declare this. Let's try to minimize collisions without making the name too ugly.
Contributor
|
@appleguy Happy to approve and land after fixing the build error ... seems like you missed a place were we used |
maicki
changed the title
Contributor
|
@appleguy I would like to get that in sooner or later so I fixed the remaining problem. |
Member
Author
|
@maicki thank you! I just wrapped up a key work milestone today and was circling back to fix this. It's a great surprise to have it already pushed :). This is still blocked on a review, so once it is accepted we can land it. Feel free to trigger the merge once you're ready. |
Adlai-Holler
approved these changes
Apr 27, 2017
Adlai-Holler
left a comment
Adlai-Holler
left a comment
Member
There was a problem hiding this comment.
Yep this has been a long time coming! Glad to see this done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some other frameworks also declare this. Let's try to minimize collisions
without making the name too ugly.