Add missing flags for ASCollectionDelegate#718
Merged
nguyenhuy merged 2 commits intoDec 19, 2017
Conversation
|
|
maicki
self-requested a review
December 15, 2017 18:36
Contributor
|
@ilyailya Hey, looks good, but please could you add an entry to the CHANGELOG.md and sign the cla. Thanks! |
Contributor
Author
|
@maicki, done! |
maicki
approved these changes
Dec 17, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Add missing flags for ASCollectionDelegate * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
collectionNode:willDisplaySupplementaryElementWithNode:andcollectionNode:didEndDisplayingSupplementaryElementWithNode:ofASCollectionDelegatearen't called in any conditions. It's happening because corresponding flags aren't added to_asyncDelegateFlags. My pull request fixes this issue.