Skip to content

Node tint color#764

Merged
Adlai-Holler merged 1 commit into
TextureGroup:masterfrom
vlchapaev:master
Feb 1, 2018
Merged

Node tint color#764
Adlai-Holler merged 1 commit into
TextureGroup:masterfrom
vlchapaev:master

Conversation

@vlchapaev

Copy link
Copy Markdown
Contributor

I faced a small problem with tint color when working with TableView cells. If you create cell in a table view, set accessory and tint color, then tint color will not apply to cell.

func tableNode(_ tableNode: ASTableNode, nodeBlockForRowAt indexPath: IndexPath) -> ASCellNodeBlock {
     return {
          let cellNode = ASCellNode()
          cellNode.accessoryType = .checkmark
          cellNode.tintColor = .orange
          return cellNode
     }
} 

It happens because tintColor wasn't pass inside ASTableView. I fixed it so setting tintColor works fine now.

@CLAassistant

CLAassistant commented Jan 23, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Adlai-Holler Adlai-Holler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a second to understand this but it makes perfect sense – we want the tint color to propagate out from the cell node to the actual cell.

Thanks @ShogunPhyched

@ghost

ghost commented Jan 31, 2018

Copy link
Copy Markdown
1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

@Adlai-Holler

Copy link
Copy Markdown
Member

@ShogunPhyched Alright if you'll update the change log, I'll land this today.

@vlchapaev

Copy link
Copy Markdown
Contributor Author

@Adlai-Holler I've already deleted my fork for Texture, so I'm unable to change anything in this pull request. Do you want me to create a new pull request?

@Adlai-Holler

Copy link
Copy Markdown
Member

@ShogunPhyched Ah, no big deal man. I'll land this and manually update the change log. Thanks for the fix, I bet other people faced this too.

@Adlai-Holler
Adlai-Holler merged commit 0f061b4 into TextureGroup:master Feb 1, 2018
Adlai-Holler pushed a commit that referenced this pull request Feb 1, 2018
@vlchapaev

Copy link
Copy Markdown
Contributor Author

@Adlai-Holler okay, thanks.

bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants