[ASDisplayNode] Fix an issue that causes a node to sometimes return an outdated calculated size or size range#808
Conversation
nguyenhuy
changed the title
…n outdated calculated size or size range
eda7613 to
d509970
Compare
| } | ||
|
|
||
| CGSize boundsSizeForLayout = ASCeilSizeValues(bounds.size); | ||
| NSUInteger calculatedVersion = _calculatedDisplayNodeLayout->version; |
There was a problem hiding this comment.
Note to reviewers: No change in the logic of this method (-_u_measureNodeWithBoundsIfNecessary:), just call the new isValid() function to (hopefully) increase readability.
30b1c9d to
a406cef
Compare
maicki
left a comment
maicki
left a comment
There was a problem hiding this comment.
Nice! Also great to increase our test base.
|
@nguyenhuy any updates on this? |
|
@nguyenhuy should we be moving forward on this? I'm considering (finally) pulling in the _layoutVersion changes, which I avoided for a while...wondering if this is an important fix before doing so. cc @maicki, @Adlai-Holler |
Adlai-Holler
left a comment
Adlai-Holler
left a comment
There was a problem hiding this comment.
Looks good! I should have had this logic from the beginning.
We should never return any layout whose version is out of date, period
|
Wooohoo 🙌 🎉 ! I depended heavily on this feature working. Thank you so much guys 😄 |
|
@Adlai-Holler Thanks for syncing with master! |
5 participants
When asked for the calculated size or constrained size for the calculated layout, prefer the pending layout only if its version is up-to-date. This should fix the issue reported by @codeOfRobin (here) and reproducible by this sample project.