Skip to content

access view first before checking canBecome/Resign responder in becomeResponder methods #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Adlai-Holler merged 10 commits into from
Mar 29, 2018
Merged

access view first before checking canBecome/Resign responder in becomeResponder methods #829

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
929d118
fix SIMULATE_WEB_RESPONSE not imported #449
wsdwsd0829 Jul 16, 2017
dd24d8f
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 Sep 6, 2017
b8eaffa
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 Oct 4, 2017
2918ea0
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 Oct 11, 2017
9c42266
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 Oct 12, 2017
329f35f
Fix to make rangeMode update in right time
wsdwsd0829 Feb 5, 2018
5f8b7ec
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 Feb 7, 2018
d87bb11
merge master from upstream
wsdwsd0829 Feb 15, 2018
269c2ab
Merge branch 'master' of github.com:TextureGroup/Texture
wsdwsd0829 Mar 10, 2018
32b74f8
Access view first before check canBecomeFirstResponder.
wsdwsd0829 Mar 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Source/ASDisplayNode.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,12 @@ - (BOOL)__canBecomeFirstResponder

- (BOOL)__becomeFirstResponder
{
// Note: This implicitly loads the view if it hasn't been loaded yet.
[self view];

if (![self canBecomeFirstResponder]) {
return NO;
}

// Note: This implicitly loads the view if it hasn't been loaded yet.
[self view];

HANDLE_NODE_RESPONDER_METHOD(becomeFirstResponder);
}
Expand All @@ -910,13 +910,13 @@ - (BOOL)__canResignFirstResponder

- (BOOL)__resignFirstResponder
{
// Note: This implicitly loads the view if it hasn't been loaded yet.
[self view];

if (![self canResignFirstResponder]) {
return NO;
}

// Note: This implicitly loads the view if it hasn't been loaded yet.
[self view];

HANDLE_NODE_RESPONDER_METHOD(resignFirstResponder);
}

Expand Down