Skip to content

Simplify Hashing Code#86

Merged
Adlai-Holler merged 3 commits into
masterfrom
AHSimplerHashing
Apr 29, 2017
Merged

Simplify Hashing Code#86
Adlai-Holler merged 3 commits into
masterfrom
AHSimplerHashing

Conversation

@Adlai-Holler

@Adlai-Holler Adlai-Holler commented Apr 29, 2017

Copy link
Copy Markdown
Member
  • New function ASHashBytes copied from CFHashBytes
  • Replaces all other hashing code.
  • Much of the hashing code was unused.

nguyenhuy
nguyenhuy approved these changes Apr 29, 2017
View reviewed changes

@nguyenhuy nguyenhuy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maicki
maicki approved these changes Apr 29, 2017
View reviewed changes

@maicki maicki left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually how NSCache does hashing in their libcache callbacks. Looks good to me too.

@Adlai-Holler
Adlai-Holler merged commit 456dc85 into master Apr 29, 2017
@Adlai-Holler
Adlai-Holler deleted the AHSimplerHashing branch April 29, 2017 22:23
@CoderXL CoderXL mentioned this pull request Sep 28, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maicki maicki maicki approved these changes
@nguyenhuy nguyenhuy nguyenhuy approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Adlai-Holler @maicki @nguyenhuy