Conversation
This is a simple additional fix to the last YOGA patch.
Generated by 🚫 Danger |
maicki
approved these changes
Apr 29, 2017
nguyenhuy
approved these changes
Apr 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple additional fix to the last Yoga patch. I was going to
upload it into the same diff, but fell behind for a couple days and
didn't realize it was of interest to converge this area.
I have no other immediate plans to submit more changes here. However
I am planning to re-work the yoga integration to reduce its footprint
and improve its reliability.
It would be awesome if there's any way I can keep up on plans in this area,
so that my design to improve the integration and make it more clean are
as applicable as possible. Let me know if I can help!