Skip to content

Fix for finding the longest word in terms of size instead of characte… #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davevdveen wants to merge 1 commit into from
Closed

Fix for finding the longest word in terms of size instead of characte… #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions Source/TextKit/ASTextKitFontSizeAdjuster.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,25 +153,29 @@ - (CGFloat)scaleFactor
// 2. The entire text fits in the given constrained size.

NSString *str = textStorage.string;
NSArray *words = [str componentsSeparatedByCharactersInSet:[NSCharacterSet whitespaceCharacterSet]];
NSString *longestWordNeedingResize = @"";
NSArray *words = [str componentsSeparatedByCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
NSUInteger location = 0; // Keep track of location to skip already evaluated text
CGSize longestWordSize = CGSizeZero;
for (NSString *word in words) {
if ([word length] > [longestWordNeedingResize length]) {
longestWordNeedingResize = word;
if(word.length == 0) {
continue;
}

NSRange wordRange = [str rangeOfString:word options:0 range:NSMakeRange(location, str.length - location)];
NSAttributedString *attrString = [textStorage attributedSubstringFromRange:wordRange];
CGSize wordSize = [attrString boundingRectWithSize:CGSizeMake(CGFLOAT_MAX, CGFLOAT_MAX) options:NSStringDrawingUsesLineFragmentOrigin context:nil].size;

if (wordSize.width > longestWordSize.width) {
longestWordSize = wordSize;
}

location = wordRange.location + wordRange.length;
}

// check to see if we may need to shrink for any of these things
BOOL longestWordFits = [longestWordNeedingResize length] ? NO : YES;
BOOL longestWordFits = CGSizeEqualToSize(longestWordSize, CGSizeZero) ? YES : NO;
BOOL maxLinesFits = _attributes.maximumNumberOfLines > 0 ? NO : YES;
BOOL heightFits = isinf(_constrainedSize.height) ? YES : NO;

CGSize longestWordSize = CGSizeZero;
if (longestWordFits == NO) {
NSRange longestWordRange = [str rangeOfString:longestWordNeedingResize];
NSAttributedString *attrString = [textStorage attributedSubstringFromRange:longestWordRange];
longestWordSize = [attrString boundingRectWithSize:CGSizeMake(CGFLOAT_MAX, CGFLOAT_MAX) options:NSStringDrawingUsesLineFragmentOrigin context:nil].size;
}

// we may need to shrink for some reason, so let's iterate through our scale factors to see if we actually need to shrink
// Note: the first scale factor in the array is 1.0 so will make sure that things don't fit without shrinking
Expand Down