Make mouse back/forward buttons navigate reader history - #1
Merged
Conversation
Mouse side buttons (back/forward) previously triggered the browser's own navigation instead of the reader's internal navigateBack/ navigateForward, unlike the equivalent Alt+Left/Right shortcuts and dedicated keyboard browser-back/forward keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reader.navigateBack()/navigateForward().mouseuplistener inKeyboardManager(the default browser action for these buttons fires onmouseup, notmousedown/pointerdown) that interceptsbutton === 3(back) andbutton === 4(forward), prevents the default navigation, and callsthis._reader.navigateBack()/navigateForward()instead.Test plan
Generated by Claude Code