[blairg23]

## 🧾 Title
feat(ci): add Codecov coverage reporting (#188)

🧠 Description

Wires up test coverage upload to Codecov on every push and PR so the team has visibility into coverage trends and regressions are surfaced before merge.

🧩 Changes Included

• Updated environment configuration
• Implemented new feature or enhancement

🎯 Purpose

This PR adds Codecov integration so coverage is tracked automatically on every CI run, with PR diff comments showing coverage delta.

🔗 Related Issues / Epics

• Epic: Foundation — platform spine, auth, and deployment baseline  #189
• Issue: Add Codecov integration for test coverage tracking #188
• Closes Add Codecov integration for test coverage tracking #188

🧪 Testing

1. Merge and push -- verify CI runs the coverage step without error
2. Check codecov.io/gh/ThePRIMEForge/muster-deck -- confirm report appears
3. Open a follow-up PR -- verify Codecov posts a coverage comment

🧰 Developer Notes

• Uses Node's built-in --experimental-coverage --coverage-reporter=lcov (Node 22 LTS)
• fail_ci_if_error: false so missing coverage never blocks a green build
• codecov.yml: 70% project target, 60% patch target, comments on changes only

[cmFrameShift]

Review: the coverage step is currently a silent no-op

Good to get coverage tracking wired up, and the codecov.yml config looks fine on its own (70/60 targets, require_changes on the comment). The problem is in the CI step. I ran it against a live Node, and the failure mode is sneaky: it passes CI green while running no tests and uploading no coverage.

Blocking: the Node coverage flags do not exist

node --experimental-coverage --coverage-reporter=lcov --test ... || true

Node rejects both flags:

node: bad option: --experimental-coverage
node: bad option: --coverage-reporter=lcov

The correct flags, which I verified produce a real coverage/lcov.info:

• --experimental-test-coverage, not --experimental-coverage
• --test-reporter=lcov. lcov is a reporter, not a coverage flag.
• --test-reporter-destination=coverage/lcov.info

Here is the trap. The command ends in || true, so Node's "bad option" exit code of 1 gets swallowed and the step exits 0. No tests run and no lcov.info is written. The Codecov step then finds no file, but fail_ci_if_error: false keeps it green. So the green check is not evidence that any of this works.

Should fix before merge

• || true also masks real test failures. fail_ci_if_error: false already covers "missing coverage never blocks." But || true on the test command means failing tests can never break the build either, which I do not think is intended. Drop it, or scope the non-blocking behavior to the upload step only.
• Missing mkdir -p coverage. The lcov reporter errors with ENOENT until the destination directory exists.
• The inline glob list duplicates the one already in the test script in package.json. Two copies will drift. Better to add a test:coverage script and have CI call npm run test:coverage, so the file list lives in one place.
• With only --test-reporter=lcov, the CI log shows no per-test pass or fail output. Add a second --test-reporter=spec --test-reporter-destination=stdout if you want both.

Minor, worth checking

• Confirm secrets.CODECOV_TOKEN is set in the repo Actions secrets, or uploads fail. Given fail_ci_if_error: false, they fail silently.
• Glob no-match: if a directory ever has no test file, the shell passes the literal glob to Node and it errors. Currently hidden by || true.
• Node version is fine. CI uses lts/*, and these flags need Node 22 or newer.

Suggested shape

- name: Test with coverage
  run: |
    if npm run | grep -qE '^[[:space:]]+test'; then
      mkdir -p coverage
      npm run test:coverage
    else
      echo "No test script defined; skipping tests."
    fi

with test:coverage in package.json carrying the corrected flags and the single copy of the test glob list.

[blairg23]

Fixed in 3dd70be. Added test:coverage script to package.json with the correct Node flags (--experimental-test-coverage, --test-reporter=lcov/spec), dropped || true, added mkdir -p coverage, and updated ci.yml to call npm run test:coverage so the glob list lives in one place.