Game does not capture cursor in windowed mode #104

Activity

1. xezon

   added

   BugSomething is not working right, typically is user facingSomething is not working right, typically is user facing

   GenToolRelates to GenToolRelates to GenTool

   CriticalSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < Blocker

   ExecutableIs game code relatedIs game code related

   on Oct 8, 2021
2. xezon

   closed this as completedon Oct 8, 2021
3. xezon

   reopened this on Dec 21, 2021
4. xezon

   transferred this issue fromTheSuperHackers/GeneralsGamePatchon Feb 28, 2025
5. ShizCalev commented on Mar 3, 2025

   

   ShizCalev

   on Mar 3, 2025

   Last edited by ShizCalev

   More actions

   looks like the game already has the proper logic for releasing capture when minimizing. ClipCursor() is only getting called when there's specifically a directinput mouse though, which might be the actual issue
   

   GeneralsGameCode/Generals/Code/Main/WinMain.cpp

   Lines 443 to 469 in 0a05454

   	//-------------------------------------------------------------------------
   	case WM_ACTIVATE:
   	{
   	Int active = LOWORD( wParam );
   	//
   	// when window is becoming deactivated we must release mouse cursor
   	// locks on our region, otherwise set the mouse limit region again
   	// which will clip the cursor to our window
   	//
   	if( active == WA_INACTIVE )
   	{
   	ClipCursor( NULL );
   	if (TheAudio)
   	TheAudio->loseFocus();
   	} // end if
   	else
   	{
   	if( TheMouse )
   	TheMouse->setMouseLimits();
   	if (TheAudio)
   	TheAudio->regainFocus();
   	} // end else
   	break;

   
   

   GeneralsGameCode/Generals/Code/GameEngineDevice/Source/Win32Device/GameClient/Win32DIMouse.cpp

   Lines 407 to 433 in 0a05454

   	void DirectInputMouse::setMouseLimits( void )
   	{
   	//
   	// extending functionality, although we may overwrite the limits set
   	// from the base class
   	//
   	Mouse::setMouseLimits();
   	//
   	// when runing windowed we want to keep the mouse within the game
   	// window cause it's annoying to mouse out of the window and click
   	// on a background window.
   	//
   	if( TheDisplay && TheDisplay->getWindowed() == TRUE )
   	{
   	RECT windowRect;
   	// get the window rect
   	GetWindowRect( ApplicationHWnd, &windowRect );
   	// keep the cursor clipped to these coords when running windowed
   	ClipCursor( &windowRect );
   	} // end if
   	} // end setMouseLimits

   
   

   GeneralsGameCode/Generals/Code/GameEngine/Source/GameClient/Input/Mouse.cpp

   Lines 945 to 958 in 0a05454

   	void Mouse::setMouseLimits( void )
   	{
   	m_minX = 0;
   	m_minY = 0;
   	if( TheDisplay )
   	{
   	m_maxX = TheDisplay->getWidth();
   	m_maxY = TheDisplay->getHeight();
   	} // end if
   	} // end setMouseLimits
6. tintinhamans

   added the

   Bug

   issue type on Mar 4, 2025
7. tintinhamans

   removed the

   Bug

   issue type on Mar 4, 2025
8. DevGeniusCode

   added the

   Bug

   issue type on Mar 4, 2025
9. DevGeniusCode

   added

   ZHRelates to Zero HourRelates to Zero Hour

   and removed

   ExecutableIs game code relatedIs game code related

   on Mar 4, 2025
10. xezon

    added

    EnhancementIs new feature or requestIs new feature or request

    and removed

    BugSomething is not working right, typically is user facingSomething is not working right, typically is user facing

    ZHRelates to Zero HourRelates to Zero Hour

    on Jul 27, 2025
11. xezon

    closed this as completedin #1369on Aug 11, 2025
12. L3-M

    added this to the GenTool features replication milestone on Sep 7, 2025
13. vitimiti

    added a commit that references this issue on Nov 11, 2025

    # This is a combination of 977 commits.

    ...

    ea36351