a typo in Bool AIGroup::getMinMaxAndCenter()

Prerequisites

I have searched for similar issues and confirmed this is not a duplicate

Game Version

Command & Conquer Generals
Command & Conquer Generals: Zero Hour
Other (please specify below)

Bug Description

if (count==0) {
	id = curID;
} else {
	if (id == NO_FORMATION_ID) {
		id = NO_FORMATION_ID;
	}
}

Reproduction Steps

no need

Additional Context

No response

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIGroup.cpp

Lines 412 to 419 in 1c1a9bf

    
           FormationID curID = (*i)->getFormationID() ; 
        
           if (count==0) { 
        
           	id = curID; 
        
           } else { 
        
           	if (id == NO_FORMATION_ID) { 
        
           		id = NO_FORMATION_ID; 
        
           	} 
        
           }

I don't think the entire else-section is needed at all.

I assume the idea was to do this:

 FormationID curID = (*i)->getFormationID() ; 
 if (count==0) { 
 	id = curID; 
 } else { 
 	if (curID == NO_FORMATION_ID) { // id --> curID
 		id = NO_FORMATION_ID; 
 	} 
 }

Navigation Menu

Repository navigation

a typo in Bool AIGroup::getMinMaxAndCenter() #3350

Prerequisites

Game Version

Bug Description

Reproduction Steps

Additional Context

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	FormationID curID = (*i)->getFormationID() ;
	if (count==0) {
	id = curID;
	} else {
	if (id == NO_FORMATION_ID) {
	id = NO_FORMATION_ID;
	}
	}

a typo in Bool AIGroup::getMinMaxAndCenter() #3350

Description

Prerequisites

Game Version

Bug Description

Reproduction Steps

Additional Context

Activity

Caball009 commented on Sep 23, 2026

Skyaero42 commented on Sep 23, 2026

Caball009 commented on Sep 23, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions