You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Starting a Comment here with warnings that won't get changes in this first pass that could lead to changes in behaviour, will keep it updated as new things appear.
File - Line - Bug - Info
[ZH] BuddyThread.cpp - 363 - Fallthrough in Switch case - BUDDYREQUEST_DENYADD is missing a break and will fall into BUDDYREQUEST_SETSTATUS
[ZH] LookAtXlat.cpp - 374 - Fallthrough in Switch case - MSG_RAW_MOUSE_WHEEL falls into MSG_META_OPTIONS but has a comment stating this should happen, it would be safer to just call "stopScrolling()" at the end of MSG_RAW_MOUSE_WHEEL
[ZH] PeerThread.cpp - 189 - Uninitialsed Variables - PeerThreadClass constructor only partialy initialises the object.
[ZH] registry.cpp - 25 - Macro Redefinition - WIN32_LEAN_AND_MEAN is considered redefined.
[ZH] ControlBar.h - 481->486 - Missing Function Definitions - Destructor, init, reset, update and draw functions all lack bodies.
[ZH] ControlBar.h - 452 - Uninitialised Variables - Constructor only partially initialises the object.
[ZH] PeerThread.h - 46->174 - Uninitialised Varaibles - PeerRequest class contains structs with uninitialised variables.
[ZH] FlightDeckBehavior.cpp - 198 - Discarding return value - return value from iterator is ignored
[ZH] FlightDeckBehavior.cpp - 1360 - Null pointer dereference - no guard against null pointer dereferencing
[ZH] FlightDeckBehavior.cpp - 61 - Uninitialised Variables - FlightDeckBehaviorModuleData constructor only partially initialised the object.
The only warnings that can be fixed at Level 2 are enumerations that were made static by someone, they were likely thinking it would make them internal to the compilation unit. But that is not what static means in C++ compared to C.
Activity
Mauller commentedon Mar 28, 2025
Starting a Comment here with warnings that won't get changes in this first pass that could lead to changes in behaviour, will keep it updated as new things appear.
File - Line - Bug - Info
[ZH] BuddyThread.cpp - 363 - Fallthrough in Switch case - BUDDYREQUEST_DENYADD is missing a break and will fall into BUDDYREQUEST_SETSTATUS
[ZH] LookAtXlat.cpp - 374 - Fallthrough in Switch case - MSG_RAW_MOUSE_WHEEL falls into MSG_META_OPTIONS but has a comment stating this should happen, it would be safer to just call "stopScrolling()" at the end of MSG_RAW_MOUSE_WHEEL
[ZH] PeerThread.cpp - 189 - Uninitialsed Variables - PeerThreadClass constructor only partialy initialises the object.
[ZH] registry.cpp - 25 - Macro Redefinition - WIN32_LEAN_AND_MEAN is considered redefined.
[ZH] ControlBar.h - 481->486 - Missing Function Definitions - Destructor, init, reset, update and draw functions all lack bodies.
[ZH] ControlBar.h - 452 - Uninitialised Variables - Constructor only partially initialises the object.
[ZH] PeerThread.h - 46->174 - Uninitialised Varaibles - PeerRequest class contains structs with uninitialised variables.
[ZH] FlightDeckBehavior.cpp - 198 - Discarding return value - return value from iterator is ignored
[ZH] FlightDeckBehavior.cpp - 1360 - Null pointer dereference - no guard against null pointer dereferencing
[ZH] FlightDeckBehavior.cpp - 61 - Uninitialised Variables - FlightDeckBehaviorModuleData constructor only partially initialised the object.
Mauller commentedon Mar 28, 2025
The only warnings that can be fixed at Level 2 are enumerations that were made static by someone, they were likely thinking it would make them internal to the compilation unit. But that is not what static means in C++ compared to C.
So i will move those fixes into level 3 warnings.