chore(drawable): Remove obsolete RECOIL_FROM_BEING_DAMAGED code in Drawable::calcPhysicsXformTreads()

[xezon]

This change removes the obsolete RECOIL_FROM_BEING_DAMAGED code in Drawable::calcPhysicsXformTreads. It does not compile.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2eb587db-0d0e-436b-b588-08664838811a

---

📥 Commits

Reviewing files that changed from the base of the PR and between ac4965a and 1fe627e.

---

📒 Files selected for processing (2)

• Generals/Code/GameEngine/Source/GameClient/Drawable.cpp
• GeneralsMD/Code/GameEngine/Source/GameClient/Drawable.cpp

---

💤 Files with no reviewable changes (2)

• Generals/Code/GameEngine/Source/GameClient/Drawable.cpp
• GeneralsMD/Code/GameEngine/Source/GameClient/Drawable.cpp

---

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

---

---

Walkthrough

Tread physics no longer applies randomized pitch and roll recoil when damage exceeds the recoil threshold. The change removes this behavior from both Generals and GeneralsMD.

Changes

Tread physics

Layer / File(s)	Summary
Remove damage-triggered tread recoil Generals/Code/GameEngine/Source/GameClient/Drawable.cpp, GeneralsMD/Code/GameEngine/Source/GameClient/Drawable.cpp	Both versions no longer check damage timestamps or amounts, look up the attacker, or apply randomized pitch and roll recoil in Drawable::calcPhysicsXformTreads.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 1fe62

No issue attributable to the recoil removal is established. Run the normal build checks before merging, particularly because the author reported a compilation failure.

Pre-merge checks | 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the removal of obsolete RECOIL_FROM_BEING_DAMAGED code from Drawable::calcPhysicsXformTreads, which matches the main changeset.
Description check		The description accurately identifies the removed code and reports the compilation issue. It is related to the changeset.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Low impact] This cleanup appears safe to merge.

Summary

Removes obsolete damage-recoil code from Drawable::calcPhysicsXformTreads() in both game variants.

• Tracked vehicles no longer get a chassis kick from damage.

_{Reviews (1) · Last reviewed commit: "chore(drawable): Remove obsolete RECOIL_..." · Reviewed by Greptile}

[Mauller]

Was the idea behind this to make the vehicle rock when struck?

[xezon]

Yes it seems so. But only for treads, not the others. Imo if we want this later on we can just implement this anew for all of them.