bugfix(gui): Only attach push button data to push button windows

[tintinhamans]

GadgetButtonSetBorder, GadgetButtonDrawClock, GadgetButtonDrawInverseClock, GadgetButtonDrawOverlayImage and GadgetButtonSetData allocate a PushButtonData on whatever window they get. Only GadgetPushButtonSystem frees it on GWM_DESTROY, so on any other window it leaks.

Headless mode hits this every match: every window lookup resolves to the dummy window, whose system ignores GWM_DESTROY. The debug leak report of a headless replay grows by six blocks per match from this alone.

The setters now skip windows without GWS_PUSH_BUTTON, same check setControlCommand already makes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 96ab3883-4ba1-4675-a718-4592d04c149f

📥 Commits

Reviewing files that changed from the base of the PR and between a112357 and 90622b0.

📒 Files selected for processing (1)

• Core/GameEngine/Source/GameClient/GUI/Gadget/GadgetPushButton.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

Push-button operations now check that a window is non-null and has the GWS_PUSH_BUTTON style before changing button data or drawing button elements.

Changes

Push-button window guards

Layer / File(s)	Summary
Style check and operation guards Core/GameEngine/Source/GameClient/GUI/Gadget/GadgetPushButton.cpp	A new helper checks for a non-null window with the GWS_PUSH_BUTTON style. GadgetButtonSetBorder, GadgetButtonDrawClock, GadgetButtonDrawInverseClock, GadgetButtonDrawOverlayImage, and GadgetButtonSetData now return when this check fails.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: skyaero42

Merge Risk: ⚪ Minimal · up to 90622

No verified user-facing regression remains. The external ControlBar layout styles are unknown, but available code evidence does not establish that the new guards suppress required updates.

Pre-merge checks · 4

Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the bug fix and matches the main change: limiting push button data to push button windows.
Description check		The description explains the memory leak, affected functions, headless replay impact, and implemented fix. It is directly related to the changeset.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Restricts five button setters to windows with GWS_PUSH_BUTTON.

• Push-button helpers only attach their data to push-button windows.

_{Reviews (2) · Last reviewed commit: "bugfix(gui): Only attach push button dat..." · Reviewed by Greptile}