Skip to content

Fix: Set better name for China Helix in Polish strings - #2265

Merged
xezon merged 1 commit into
mainfrom
text-polish-helix-name
Aug 27, 2023
Merged

xezon merged 1 commit into
mainfrom
text-polish-helix-name

Conversation

@xezon

@xezon xezon commented Aug 21, 2023 •

Copy link
Copy Markdown
Contributor

This change sets appropriate name for China Helix in Polish strings. It is now called "Helis" instead of "Spiral".

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker China Affects China faction Text Is text, string, localization related labels Aug 21, 2023
@xezon xezon changed the title Fix: Sets appropriate name for China Helix in Polish strings Fix: Set better name for China Helix in Polish strings Aug 21, 2023
@xezon
xezon force-pushed the text-polish-helix-name branch from ae90b9d to 39191d8 Compare August 21, 2023 16:12
@xezon
xezon force-pushed the text-polish-helix-name branch from 39191d8 to b5ae138 Compare August 27, 2023 12:09
@xezon
xezon force-pushed the text-polish-helix-name branch from b5ae138 to 0854bc0 Compare August 27, 2023 12:18
@xezon

xezon commented Aug 27, 2023

Copy link
Copy Markdown
Contributor Author

Need to have a Polish guy one day who can double check the polish edits. But for now looks ok. Documentation added.

@xezon
xezon merged commit 8f1ff0d into main Aug 27, 2023
@xezon
xezon deleted the text-polish-helix-name branch August 27, 2023 12:23

@CrabHead CrabHead left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR. Needs some changes, mainly from "Helisi" to "Helisy". Other than that all is correct

ZH: "讓螺旋直昇機擁有汽油彈投擲能力"
BP: "Habilite este Helix para lançar bombas de napalm."
PL: "Umożliwia tej Spirali zrzucanie bomb z napalmem"
PL: "Umożliwia tej Helisi zrzucanie bomb z napalmem"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

ZH: "讓螺旋直昇機擁有核彈投擲能力"
BP: "Habilite este Helix para lançar bombas nucleares."
PL: "Umożliwia tej Spirali zrzucanie atomówek"
PL: "Umożliwia tej Helisi zrzucanie atomówek"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

ZH: "螺旋直昇機蓋特機砲"
BP: "Canhão Gattling do Helix"
PL: "Działko gattling Spirali"
PL: "Działko gattling Helisi"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "gattling" to "gatling" and "Helisi" to "Helisy"

ZH: "螺旋直昇機思想強化電塔"
BP: "Torre de Propaganda do Helix"
PL: "Megafon Spirali"
PL: "Megafon Helisi"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

ZH: "螺旋直昇機碉堡"
BP: "Bunker de Combate do Helix"
PL: "Bunkier bojowy Spirali"
PL: "Bunkier bojowy Helisi"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

ZH: "在螺旋直昇機上增設蓋特機砲"
BP: "Equipa este Helix com um Canhão Gattlin"
PL: "Uzbrojenie Spirali w działko gattling"
PL: "Uzbrojenie Helisi w działko gattling"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

ZH: "在螺旋直昇機上增設思想強化電塔"
BP: "Equipa este Helix com uma Torre de Propaganda"
PL: "Wyposażenie Spirali w megafony"
PL: "Wyposażenie Helisi w megafony"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

ZH: "在螺旋直昇機上增設碉堡,碉堡可讓您的士兵進駐,士兵可從碉堡內對外開火"
BP: "Equipa este Helix com um Bunker. Os Bunkers podem ser ocupados por soldados. Os soldados podem disparar dos Bunkers"
PL: "Wyposażenie Spirali w bunkier. Bunkier może być obsadzony żołnierzami, którzy mogą się wtedy ostrzeliwać"
PL: "Wyposażenie Helisi w bunkier. Bunkier może być obsadzony żołnierzami, którzy mogą się wtedy ostrzeliwać"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

@dmgreeny

dmgreeny commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

This change was additionally improved here #2635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

China Affects China faction Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants