Add missing text lines by dmgreeny · Pull Request #2571 · TheSuperHackers/GeneralsGamePatch

dmgreeny · 2024-12-17T08:24:24Z

Edits only to TBD lines and empty lines at the end of generals str. They were recreated from German or Russian which were translated to English, and then they were translated to all missing languages.

xezon · 2024-12-25T07:24:50Z

@@ -101153,50 +101153,50 @@ UK: "Дозволяє викликати бомбардувальник B2 дл
 END

 GUI:LoadReplayLong


Could you find out where this string was used in the R.G.Mechanics version? I think it originated from there when we copied Russian lang.

We have GUI:LoadReplay from which I took text lines. How can I find where this string was used?

It would be referenced in one of the WND files of the R.G.Mechanics version.

Unfortunately, there are no .wnd files after I installed R.G.Mechanics version. Where can I find them?

xezon · 2024-12-25T07:33:41Z

@@ -101219,34 +101219,34 @@ END

 // context: Tooltip displayed when the user mouses over the Streak 3 battle honor icon
 TOOLTIP:BattleHonorStreak3Disabled


Is this string actually used in the screen?

It looks like there are generic strings with TOOLTIP:BattleHonorStreakDisabled, TOOLTIP:BattleHonorStreakOnlineDisabled

Is there a way to find out?

xezon · 2025-01-07T18:37:02Z

+BP: "Temos uniformes bonitos... venha nos ver... você vai gostar.\nOu não."
+PL: "Mamy ładne mundury... przyjdź i zobacz nas... spodoba ci się.\nAlbo nie."
+RU: "У нас красивая униформа... приходите к нам... вам понравится.\nИли нет"
+AR: "لدينا زي رسمي لطيف... تعال وشاهدنا... سوف يعجبك.\nأو لا."


Arabic text is right to left, so it seems odd that sentences start with a dot. Several times in this change.

xezon · 2025-01-07T18:42:40Z

 END

 // context: Tooltip displayed when the user mouses over the Streak 20 battle honor icon
 TOOLTIP:BattleHonorStreak20


Is this tool tip actually used in the game? If yes, then the number list for "Earn a new medal for 3, 10, 25, 100, 500 & 1000 consecutive wins" would need updating.

I think that its not used at least for single player statistic

xezon · 2025-01-07T18:48:33Z

-PL: ""
-RU: "Медаль за Стойкость\nВыиграйте 3 или более игр подряд, чтобы получить эту медаль"
-AR: ""
+US: "Streak Honor\nPlayer has won 3 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1000 consecutive wins"


I don't think this description is correct. It probably should be closer to TOOLTIP:BattleHonorStreakDisabled. But I suspect it is unused and therefore we do not need a text. But I do not know.

xezon · 2025-01-07T18:49:56Z

@@ -101153,50 +101153,50 @@ UK: "Дозволяє викликати бомбардувальник B2 дл
 END

 GUI:LoadReplayLong


It would be referenced in one of the WND files of the R.G.Mechanics version.

28.02.25 fixes

01.03 Removed Arabic lines

dmgreeny · 2025-03-01T05:40:12Z

I removed all added Arabic lines in this change. They will be added separately after we get Arabic loca working properly.

01.03 numbers fixed

TheMyFish · 2025-03-04T19:55:28Z

+IT: "Dove sono le mie truppe? Per favore, lasciatemi andare, ok? Non fatemi del male!"
+KO: "내 병사들은 어디 있지? 제발 날 보내줘, 알았지? 날 다치게 하지 마!"
+ZH: "我的部隊在哪裡？請讓我走，好嗎？別傷害我！"
+BP: "Onde estão minhas tropas? Por favor, deixe-me ir, ok? Não me machuque!"


I think it makes the sentence more fluid.
BP: "Onde estão as minhas tropas? Por favor, deixa-me ir, está bem? Não me façam mal!"

TheMyFish · 2025-03-04T20:01:54Z

+IT: "Abbiamo delle belle uniformi...venite a trovarci...vi piaceranno.\nOppure no."
+KO: "우리는 멋진 유니폼을 가지고 있습니다... 와서 보세요... 마음에 들어하실 겁니다.\n아니면 그렇지 않을 수도 있습니다."
+ZH: "我們有漂亮的製服...來看看我們...您會喜歡的。"
+BP: "Temos uniformes bonitos... venha nos ver... você vai gostar.\nOu não."


I understand that the meaning of the phrase is to refer to a group and not a single person.
BP: "Temos uniformes bonitos... venham ver-nos... vão gostar. \nou não"

TheMyFish · 2025-03-04T20:09:17Z

+IT: "Sei stato solo fortunato, Generale. Non mi sconfiggerai di nuovo."
+KO: "당신은 그저 운이 좋았을 뿐입니다, 장군. 당신은 다시는 나를 이길 수 없을 겁니다."
+ZH: "你只是幸運，將軍。你不會再打敗我了。"
+BP: "Você teve sorte, General. Você não vai me derrotar de novo."


I changed the sentence to emphasize the question of luck.
BP: "Você apenas teve sorte, General. Você não me derrotará novamente"

TheMyFish · 2025-03-04T20:14:48Z

+IT: "Non eri pronto per questa guerra.\nRiprova se ne hai il coraggio!"
+KO: "당신은 이 전쟁에 대비하지 못했습니다. 감히 다시 시도해 보세요!"
+ZH: "你還沒準備好迎接這場戰爭。"
+BP: "Você não estava pronto para esta guerra.\nTente novamente se tiver coragem!"


I changed the meaning of courage to audacity, it makes more sense to me with the word dare.
BP: "Você não estava preparado para esta guerra. Tente novamente, se tiver audácia!"

TheMyFish · 2025-03-04T20:25:18Z

@@ -101213,40 +101213,40 @@ ZH: "所有火箭车的弹药增加 25%。"
 BP: "Todos os buggies de foguete têm 25% mais munição."


Just leaving the word plural
BP: "Todos os buggies de foguetes têm 25% mais munição."

TheMyFish · 2025-03-04T20:29:22Z

+IT: "Aggiorna l'elenco dei giochi e dei giocatori"
+KO: "게임 및 플레이어 목록 업데이트"
+ZH: "更新遊戲和玩家列表"
+BP: "Atualizar lista de jogos e jogadores"


If you have an update on games and friends. Shouldn't the context come from matches?
BP: "Atualizar lista de partidas e jogadores"

All fixed, thank you

YarPik2 · 2025-03-06T10:43:56Z

+PL: "Miałeś po prostu szczęście, Generale. Nie pokonasz mnie ponownie."
+RU: "Вам просто повезло, Генерал. Вы не сможете победить меня еще раз."
+AR: "You were just lucky, General. You won't defeat me again."
+UK: "Вам просто пощастило, Генерале. Ти мене знову не переможеш."


I think "Вам просто пощастило, Генерале. Ви не переможете мене знову." would be more correct.

YarPik2 · 2025-03-06T10:47:50Z

+PL: "Medal za dobrą passę\nGracz zwyciężył w 5 kolejnych potyczkach.\nMedal ten otrzymuje się za 3, 10, 25, 100, 500 i 1,000 zwycięstw pod rząd."
+RU: "Медаль за стойкость\nИгрок выиграл 5 игр в режиме «Схватка» подряд\nЗаработайте новую медаль за 3, 10, 25, 100, 500 и 1,000 побед подряд"
+AR: "Streak Honor\nPlayer has won 5 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1,000 consecutive wins"
+UK: "Відзнака серії\nГравець виграв 5 сутички поспіль\nОтримайте нову відзнаку за 3, 10, 25, 100, 500 і 1,000 перемог поспіль"


"Відзнака серії\nГравець виграв 5 сутичок поспіль\nОтримайте нову відзнаку за 3, 10, 25, 100, 500 і 1,000 перемог поспіль" ("сутичок" is more correct than "сутички")

YarPik2 · 2025-03-06T10:49:49Z

+PL: "Medal za dobrą passę\nGracz zwyciężył w 20 kolejnych potyczkach.\nMedal ten otrzymuje się za 3, 10, 25, 100, 500 i 1,000 zwycięstw pod rząd."
+RU: "Медаль за стойкость\nИгрок выиграл 20 игр в режиме «Схватка» подряд\nЗаработайте новую медаль за 3, 10, 25, 100, 500 и 1,000 побед подряд"
+AR: "Streak Honor\nPlayer has won 20 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1,000 consecutive wins"
+UK: "Відзнака серії\nГравець виграв 20 сутички поспіль\nОтримайте нову відзнаку за 3, 10, 25, 100, 500 і 1,000 перемог поспіль"


"Відзнака серії\nГравець виграв 20 сутичок поспіль\nОтримайте нову відзнаку за 3, 10, 25, 100, 500 і 1,000 перемог поспіль" ("сутичок" is more correct than "сутички") again...

YarPik2 · 2025-03-06T10:54:18Z

-AR: ""
-UK: "Бліц відзнака\nПеремагайте суперників за 10 хвилин або менше, щоб отримати цю медаль"
+AR: "Blitz Honor\nتغلب على خصوم الكمبيوتر في 10 دقائق أو أقل للحصول على هذه الميدالية"
+UK: "Медаль за Блиц\nПереможіть комп'ютерного опонента(ів) за 10 хвилин, щоб отримати цю медаль"


"Медаль за Бліц\nПереможіть комп'ютерного опонента(ів) за 10 хвилин, щоб отримати цю медаль"

YarPik2 · 2025-03-06T10:55:48Z

+PL: "Prośba o dodanie do znajomych została wysłana"
+RU: "Запрос на добавление в друзья был отправлен"
+AR: "A friend request has been sent"
+UK: "Запит на додавання в друзів був відправлений"


"Запит на додавання в друзі був відправлений"

YarPik2 · 2025-03-06T10:56:10Z

+PL: "Prośba o dodanie do znajomych została odrzucona"
+RU: "Запрос на добавление в друзья был отклонен"
+AR: "Friend request was rejected"
+UK: "Запит на додавання в друзів був відхилений"


"Запит на додавання в друзі був відхилений"

YarPik2 · 2025-03-06T10:57:25Z

+PL: "Prośba o dodanie do znajomych została zaakceptowana"
+RU: "Запрос на добавление в друзья принят"
+AR: "Friend request was accepted"
+UK: "Запит на додавання у друзі прийнятий"


"Запит на додавання в друзі прийнятий"

YarPik2 · 2025-03-06T10:58:23Z

+PL: "Kliknij prawym przyciskiem myszy na nazwę gracza na liście, aby wysłać prośbę o dodanie do znajomych"
+RU: "Нажмите правой кнопкой мыши по имени в списке игроков, чтобы отправить запрос на добавление в друзья"
+AR: "Right click on a name in the player list to send a friend request"
+UK: "Натисніть правою кнопкою миші по імені у списку гравців, щоб надіслати запит на додавання до друзів"


"Натисніть правою кнопкою миші по імені у списку гравців, щоб надіслати запит на додавання в друзі"

ElTioRata · 2025-03-06T18:41:42Z

-AR: "TBD"
-UK: "TBD"
+FR: "Où sont mes troupes ? Laissez-moi partir, ok ? Ne me faites pas de mal !"
+ES: "¿Dónde están mis tropas? Por favor, déjenme ir, ¿de acuerdo? ¡No me hagan daño!"


Should be "¿Dónde están mis tropas? Por favor, dejadme ir, ¿vale? ¡No me hagáis daño!"

ElTioRata · 2025-03-06T18:46:20Z

-AR: "TBD"
-UK: "TBD"
+FR: "Nous avons de beaux uniformes... venez nous voir... vous allez aimer.\nOu pas"
+ES: "Tenemos lindos uniformes...ven a vernos...te gustará.\nO no"


I'd rephrase that with other words. Should be "Tenemos unos bonitos uniformes... pásate a vernos... te gustará.\nO no."

ElTioRata · 2025-03-06T18:51:48Z

+US: "You were just lucky, General. You won't defeat me again."
+DE: "Sie hatten nur Glück, General. Nochmal schlagen Sie mich nicht."
+FR: "Vous avez eu de la chance, en général. Vous ne me vaincrez plus."
+ES: "Tuviste suerte, general. No volverás a vencerme."


Should be formal instead. "Ha tenido suerte, general. No me derrotará otra vez."

ElTioRata · 2025-03-06T18:53:32Z

-AR: "TBD"
-UK: "TBD"
+FR: "Vous n'étiez pas prêt pour cette guerre. Réessayez si vous l'osez !"
+ES: "No estabas preparado para esta guerra. ¡Inténtalo de nuevo si te atreves!"


Should be formal instead. "Usted no estaba listo para esta guerra. ¡Inténtelo de nuevo si se atreve!"

ElTioRata · 2025-03-06T18:56:35Z

+US: "Streak Honor\nPlayer has won 5 Skirmish games in a row in single or multiplayer games via the Internet"
+DE: "Streak Honor\nDer Spieler hat 5 Skirmish-Spiele in Folge in Einzel- oder Mehrspielerspielen über das Internet gewonnen"
+FR: "Série d'honneur\nLe joueur a remporté 5 parties d'escarmouche consécutives en mode solo ou multijoueur via Internet"
+ES: "Racha de honor\nEl jugador ha ganado 5 partidas de Skirmish seguidas en partidas para un jugador o para varios jugadores a través de Internet"


Should be: "Racha de honor\nEl jugador ha ganado 5 partidas seguidas de escaramuza en partidas individuales o multijugador en línea"

ElTioRata · 2025-03-06T18:58:01Z

+US: "Streak Honor\nWin 3 or more games in a row to get this medal"
+DE: "Streak Honor\nGewinne 3 oder mehr Spiele in Folge, um diese Medaille zu erhalten"
+FR: "Série d'honneur\Remportez 3 parties ou plus d'affilée pour obtenir cette médaille"
+ES: "Racha de honor\nGana 3 o más juegos seguidos para obtener esta medalla"


Should be: "Racha de honor\nGana 3 partidas seguidas o más para obtener esta medalla"

ElTioRata · 2025-03-06T19:00:05Z

+US: "Blitz Honor\nBeat computer opponent(s) in 10 minutes or less to earn this medal"
+DE: "Blitz Honor\nBesiege Computergegner in 10 Minuten oder weniger, um diese Medaille zu erhalten"
+FR: "Blitz Honor\nBattez un ou plusieurs adversaires informatiques en 10 minutes ou moins pour gagner cette médaille"
+ES: "Blitz Honor\nDerrota a los oponentes de la computadora en 10 minutos o menos para ganar esta medalla."


Should be: "Honor militar\nDerrota oponentes IA en 10 minutos o menos para ganar esta medalla."

ElTioRata · 2025-03-06T19:02:50Z

+US: "Update list of games and players"
+DE: "Liste der Spiele und Spieler aktualisieren"
+FR: "Mettre à jour la liste des jeux et des joueurs"
+ES: "Actualizar lista de juegos y jugadores"


Should be "Actualizar lista de partidas y jugadores"

ElTioRata · 2025-03-06T19:04:16Z

+US: "Right click on a name in the player list to ignore the player"
+DE: "Klicken Sie mit der rechten Maustaste auf einen Namen in der Spielerliste, um den Spieler zu ignorieren"
+FR: "Faites un clic droit sur un nom dans la liste des joueurs pour ignorer le joueur"
+ES: "Haga clic derecho en un nombre en la lista de jugadores para ignorarlo"


Should be "Haz" instead of "Haga" to keep consistency.

ElTioRata · 2025-03-06T19:04:47Z

+US: "CLEAR"
+DE: "Löschen"
+FR: "Eff."
+ES: "Borrar"


Should be uppercase like the other strings. "BORRAR"

TheMyFish · 2025-03-07T03:44:49Z

I noticed that in the latest update of the file there are still 13 sentences with TBD, and all the languages are like that.

How can I help with this?
Because it's referencing a file, right?
Example: GUI:BioDOBEntry_Pos5

What about an audio file?

dmgreeny · 2025-03-10T06:37:35Z

@TheMyFish All other TBD lines were left intentionally by the developers of the game. There's nothing to add or change in them.

dmgreeny

All fixed and ready for review

Update generals.str

2ead58e

xezon reviewed Dec 25, 2024

View reviewed changes

xezon added Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related labels Dec 25, 2024

xezon changed the title ~~Update generals.str~~ Add missing text lines Dec 25, 2024

Update generals.str

e1d9044

xezon reviewed Jan 7, 2025

View reviewed changes

dmgreeny added 4 commits February 28, 2025 12:46

Update generals.str

045e213

28.02.25 fixes

Update generals.str

0a25403

Update generals.str

3043ab6

Update generals.str

96fe54f

01.03 Removed Arabic lines

Update generals.str

ca91f9a

01.03 numbers fixed

This was referenced Mar 4, 2025

Polish localization fixes and improvements #2543

Open

English and various localization fixes and improvements #2535

Closed

Brazilian localization fixes and improvements #2542

Open

TheMyFish suggested changes Mar 4, 2025

View reviewed changes

This was referenced Mar 5, 2025

French localization fixes and improvements #2537

Closed

Spanish localization fixes and improvements #2538

Closed

Update generals.str

c0c61ca

YarPik2 suggested changes Mar 6, 2025

View reviewed changes

ElTioRata suggested changes Mar 6, 2025

View reviewed changes

Update generals.str

081b09e

dmgreeny added 2 commits March 12, 2025 13:31

Update generals.str

5e3c42e

Create 2571_Missing_lines_added.yaml

7e919c3

dmgreeny commented Mar 26, 2025

View reviewed changes

Windstalker approved these changes Apr 17, 2025

View reviewed changes

		@@ -101153,50 +101153,50 @@ UK: "Дозволяє викликати бомбардувальник B2 дл
		END

		GUI:LoadReplayLong

		@@ -101219,34 +101219,34 @@ END

		// context: Tooltip displayed when the user mouses over the Streak 3 battle honor icon
		TOOLTIP:BattleHonorStreak3Disabled

		@@ -101213,40 +101213,40 @@ ZH: "所有火箭车的弹药增加 25%。"
		BP: "Todos os buggies de foguete têm 25% mais munição."

Conversation

dmgreeny commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmgreeny Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmgreeny commented Mar 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmgreeny commented Dec 17, 2024 •

edited

Loading

dmgreeny Feb 28, 2025 •

edited

Loading

TheMyFish commented Mar 7, 2025 •

edited

Loading

dmgreeny commented Mar 10, 2025 •

edited

Loading