Skip to content

Change to Campaign lines - #2578

Open
dmgreeny wants to merge 5 commits into
mainfrom
Campaign-lines-text-fix
Open

dmgreeny wants to merge 5 commits into
mainfrom
Campaign-lines-text-fix

Conversation

@dmgreeny

Copy link
Copy Markdown
Contributor

Separate text change to Campaign lines as requested

@dmgreeny dmgreeny changed the title Update generals.str change to Campaign lines Mar 2, 2025
@dmgreeny dmgreeny changed the title change to Campaign lines Change to Campaign lines Mar 2, 2025
@DevGeniusCode DevGeniusCode added Text Is text, string, localization related Minor Severity: Minor < Major < Critical < Blocker labels Mar 2, 2025
@xezon

xezon commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

This needs documentation in str and be added to a new or existing yaml where appropriate.

TOOLTIP:Mission9_16
US: "Campaign Two"
DE: "Kampagne Zwei"
FR: "Missions 9-16"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the mouse over tooltip in campaign work? According to the context comment above this was meant to show mission information of the campaign.

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha ok that tool tip is silly. I wonder if we can add some new better texts in there.

@dmgreeny

Copy link
Copy Markdown
Contributor Author

Added comments to .str and created yaml file


// context: Tooltip for the USA campaign button located on the main menu
TOOLTIP:Campaign3
US: "Campaign 1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, so "TOOLTIP:Campaign3" string is supposed to say "Campaign 1", yes?

@Polypheides Polypheides Mar 14, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, so "TOOLTIP:Campaign3" string is supposed to say "Campaign 1", yes?

This is a silly thing because the campaign is ordered differently from Generals to ZH so if we want translation for both games we need Two copies of Generals.str one for G order and one for ZH order

TOOLTIP:Campaign1 is China for Generals
image
TOOLTIP:Campaign1
US: "Campaign 1" or "Campaign One"
TOOLTIP:Campaign2
US: "Campaign 2" or "Campaign Two"
TOOLTIP:Campaign3
US: "Campaign 3" or "Campaign Three"
TOOLTIP:Campaign3 is US for ZH
image
TOOLTIP:Campaign1
US: "Campaign 3" or "Campaign Three"
TOOLTIP:Campaign2
US: "Campaign 2" or "Campaign Two"
TOOLTIP:Campaign3
US: "Campaign 1" or Campaign One"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this fix, it shows up correctly
1
2
3

---
date: 2025-03-12

title: Fixes inconsistence in French, Italian, Brazilian, Polish, Arabic strings

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title is way too generic

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

changes:
- fix: The number of campaigns in French, Italian, Brazilian, Polish, Arabic strings is more consistent now.

subchanges:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed when empty.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@dmgreeny dmgreeny left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants