Repository navigation
Conversation
dmgreeny
added
Text
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Please add comment to top of file about which language numbers were polished.
| @@ -101173,33 +101173,33 @@ END | |||
|
|
|||
| // context: Tooltip displayed when the user mouses over the Streak 5 battle honor icon | |||
| TOOLTIP:BattleHonorStreak5 | |||
There was a problem hiding this comment.
The bottom 4 strings need to be documented that all languages except DE were added by us.
| US: "Streak Honor\nPlayer has won 10 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1000 consecutive wins" | ||
| DE: "Siegesmedaille\nDer Spieler hat 10 Gefechte in Folge gewonnen.\nFür 3, 10, 25, 100, 500 & 1000 Siege in Folge bekommst du jeweils eine Medaille." | ||
| FR: "Distinction d'enchaînement\nLe joueur a remporté 10 parties Escarmouche d'affilée.\nGagnez une nouvelle récompense pour 3, 10, 25, 100, 500 et 1000 victoires consécutives." | ||
| US: "Streak Honor\nPlayer has won 10 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1,000 consecutive wins" |
There was a problem hiding this comment.
Does the number comma really make sense? Commas are already used for the number list.
There was a problem hiding this comment.
What do you propose?
There was a problem hiding this comment.
I am fine with it, just raising that it perhaps is odd. Maybe a native US person can give their 2 cents on this.
There was a problem hiding this comment.
I added "," to US 1000, because in one of the original text lines it was written as 10,000
There was a problem hiding this comment.
ChatGPT response:
In U.S. English, it's standard to use a comma in numbers 1,000 and above (e.g., 1,000; 10,000; 100,000). So your text is correct as is.
However, some style guides (like in coding or scientific contexts) might omit the comma for readability or consistency (e.g., 1000 instead of 1,000). But in general writing, especially for things like game achievements, the comma is preferred.
| DE: "Vorherrschaftsmedaille\nDer Spieler hat über 100 Gefechte gewonnen. Nach 100, 500, 1000 und 10.000 Siegen bekommst du eine Medaille." | ||
| FR: "Distinction de domination\nLe joueur a remporté plus de 100 parties Escarmouche.\nGagnez une nouvelle récompense pour 100, 500, 1000 et 10 000 victoires consécutives." | ||
| US: "Domination Honor\nPlayer has won over 100 Skirmish games\nEarn a new medal for 100, 500, 1,000 and 10,000 lifetime wins" | ||
| DE: "Vorherrschaftsmedaille\nDer Spieler hat über 100 Gefechte gewonnen. Nach 100, 500, 1,000 und 10,000 Siegen bekommst du eine Medaille." |
There was a problem hiding this comment.
I think dot makes more sense for German numbers.
There was a problem hiding this comment.
So make it 1.000 and 10.000 for German?
There was a problem hiding this comment.
Yes I think the dot is ok for German.
dmgreeny
left a comment
dmgreeny
left a comment
There was a problem hiding this comment.
All fixed and ready for merge
As discussed here #2633